1822180 - [wpt-sync] Sync PR 38966 - Fix Clear-Site-Data WPT that clears active service worker.

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38966 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38966
Details from upstream follow.

Evan Stade <[e-mail]> wrote:

Fix Clear-Site-Data WPT that clears active service worker.

A service worker was handling the network request for an iframe page
load. That load also cleared storage (and service workers) via Clear-
Site-Data. This interrupted the page load and prevented the test from
completing.

Specifically, 'support/echo-clear-site-data.py' was returning
[Clear-Site-Data: "storage"] which clobbered the service worker which
was registered for 'support/' which prevented the subload of
'support/test_utils.sub.js'.

The solution is to narrow the scope of the service worker so that it
doesn't apply to the page the iframe is loading.

Bug: 1198698
Change-Id: I6724f5ef8e2140d031b6c570b9c708359a97d140

Reviewed-on: https://chromium-review.googlesource.com/4334942
WPT-Export-Revision: 3d7ca75aa59e693cbb5621a92bd26518970df005

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d8d335d6bf3a9c53355075548eef8476ad5a82c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 4 subtests

Status Summary

Firefox

OK : 3
PASS : 12[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 18[GitHub]
FAIL : 1
TIMEOUT: 2

Chrome

OK : 4
PASS : 22

Safari

OK : 3
PASS : 17
FAIL : 2
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /clear-site-data/storage.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
  • Service worker no longer responds to requests: FAIL (Chrome: PASS, Safari: FAIL)
  • controllerchange event fires and client no longer has controller: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

• /clear-site-data/storage.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80db1f8e1a08
[wpt PR 38966] - Fix Clear-Site-Data WPT that clears active service worker., a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/80db1f8e1a08