1822210 - Check whether the view is opening when recording telemetry

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Daisuke Akatsuka (:daisuke)]

This is a follow-up of bug 1817208.
In this bug, we will fix https://bugzilla.mozilla.org/show_bug.cgi?id=1817208#c2 case.

(In reply to Marco Bonardo [:mak] from comment #2)

Another case is typing a search, pressing ESC to close the results panel, then confirm the search with Enter, should return input_field as selected_result, instead it returns unknown.
Also why is selected_result not empty if there's no selected result? unknown should only be used when there is a selected result but we can't recognize it, maybe there's a catch-all setting to unknown even if there isn't a selected result.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1822210: Check wheather the view is opening when recording

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ee64b4b95a2
Check wheather the view is opening when recording r=mak

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7ee64b4b95a2

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

uplift to 112, just in case we want to measure there

Comment 5

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9322874 [details]
Bug 1822210: Check wheather the view is opening when recording

Beta/Release Uplift Approval Request

• User impact if declined: This change is for telemetry. So, no user impact.
  But, we want to know how the user uses the urlbar and the results more correctly to improve the user experience.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This affects only telemetry.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9322874 [details]
Bug 1822210: Check wheather the view is opening when recording

Approved for 112.0b4

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d233191c276

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx 113.0a1 and Fx 112.0b5 on Windows 10 and Ubuntu 22.04. "selected_result" field value is input_field.