1822214 - [wpt-sync] Sync PR 38969 - [FlexNG] Don't clamp flex row-gaps when fragmenting

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38969 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38969
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[FlexNG] Don't clamp flex row-gaps when fragmenting

We don't clamp flex item margins when an item breaks before to more
accurately handle alignment. Thus, we should similarly do the same
for row gaps. Currently, we will clamp row gaps (or at least part
of row gaps - there were other bugs uncovered while investigating),
so this CL updates the logic to correctly preserve the row gap,
matching Firefox's behavior.

To accomplish this, we needed to adjust item offsets based on various
cases, but we only want to make this adjustment the first time the
row breaks before. Thus, we needed to add a bit to the flex BreakToken
data to keep track of when we've processed the first row break before.

Additionally, when we perform the logic to determine if a row should
break before, we needed to update the call site to pass in the adjusted
row offset to ensure we are handling breaks correctly.

Bug: 1413089
Change-Id: Ieb9cc4470cd96146cddf4f330aefdd06af1a1626
Reviewed-on: https://chromium-review.googlesource.com/4335769
WPT-Export-Revision: 368f8fbb544efed15357292f8d43ec7a7c339cbf

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ee45e447f8e968194ab6691408bb1eebacaee52

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests

Status Summary

Firefox

PASS: 7

Chrome

PASS: 2
FAIL: 5

Safari

PASS: 6
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8164ba0a471c
[wpt PR 38969] - [FlexNG] Don't clamp flex row-gaps when fragmenting, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8164ba0a471c