1822238 - [wpt-sync] Sync PR 38975 - [ComputePressure] Refactor for better supporting different PressureSources

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38975 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38975
Details from upstream follow.

Wei4 Wang <[e-mail]> wrote:

[ComputePressure] Refactor for better supporting different PressureSources

There are two problems making it different to extend to other
PressureSources in current implementation:

1. Mojom and services side implementation does not take PressureSource
   concept into account.
2. Implementation in Blink does not deal with cases of different
   PressureSources in some functions.

This CL resolves this issue making it easier to add other
PressureSource in the future.

Bug: 1399508, 1342184
Change-Id: I8937314006c098be65bf6bb6c45b22389eee1d75
Reviewed-on: https://chromium-review.googlesource.com/4328269
WPT-Export-Revision: a355cf85aabec9d9ccfd149d8d31582d210dc769

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a91b5fc2633ac7dac2ce33632924bdf5af940f3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 1 subtests

Status Summary

Firefox

OK : 5
FAIL: 11

Chrome

OK : 5
FAIL: 11

Safari

OK : 5
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /compute-pressure/compute_pressure_basic_async.tentative.https.window.html [wpt.fyi]
  • Return NotSupportedError when calling observer(): FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling observe() multiple times works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Starting a new observer after an observer has started works: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_duplicate_updates.tentative.https.window.html [wpt.fyi]
  • Changes that fail the "has change in data" test are discarded.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Factors that fail the "has change in data" test are discarded.: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_factors.tentative.https.window.html [wpt.fyi]
  • Basic factors functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_timestamp.tentative.https.window.html [wpt.fyi]
  • Faster collector: Timestamp difference between two changes should be higher or equal to the observer sample rate: FAIL (Chrome: FAIL, Safari: FAIL)
  • disconnect() should update [[LastRecordMap]]: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_update_toJSON.tentative.https.window.html [wpt.fyi]
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb4b4dd1359
[wpt PR 38975] - [ComputePressure] Refactor for better supporting different PressureSources, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0bb4b4dd1359