Clear Exceptions reducer on each target/thread removal
Categories
(DevTools :: Debugger, task)
Tracking
(firefox114 fixed)
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(3 files)
exceptions reducer is never clearer!
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers/exceptions.js#16-22
Similarly to bug 1814177, this reducer should be clearer on each target/thread removal.
|
Assignee | |
Comment 1•1 year ago
|
||
We don't really need to clone the whole exception map every time.
And we could use a real Map object.
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
This help reduce memory footprint, especially in the MBT,
but will also help stop clearing all reducers on navigation.
|
|
Assignee | |
Comment 3•1 year ago
|
||
- avoid calling selectors when no source is selected.
- ensure returning the exact same array instance from selectors
when their content don't change, so that redux and react
doesn't try to update for no reason. - Remove hasException and instead let the reducer prevent
adding duplicated exception for same location.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a79468808b2 [devtools] Use mutable data in exceptions reducer. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/3d8515c1c6fd [devtools] Clear exceptions reducer on each thread removal. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/4289319cf412 [devtools] Optimize exception selectors. r=devtools-reviewers,nchevobbe
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9a79468808b2
https://hg.mozilla.org/mozilla-central/rev/3d8515c1c6fd
https://hg.mozilla.org/mozilla-central/rev/4289319cf412
|
||
Comment 6•1 year ago
|
||
== Change summary for alert #38113 (as of Sun, 16 Apr 2023 15:35:07 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 18% | damp browser-toolbox.debugger-ready.DAMP | macosx1015-64-shippable-qr | e10s fission stylo webrender | 1,029.57 -> 840.44 |
| 16% | damp browser-toolbox.debugger-ready.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 1,102.27 -> 926.05 |
| 16% | damp browser-toolbox.debugger-ready.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 1,109.40 -> 933.11 |
| 16% | damp browser-toolbox.debugger-ready.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 1,385.30 -> 1,166.53 |
| 16% | damp browser-toolbox.debugger-ready.DAMP | macosx1015-64-shippable-qr | e10s fission stylo webrender-sw | 1,022.09 -> 862.89 |
| 16% | damp browser-toolbox.debugger-ready.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 1,379.18 -> 1,165.29 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38113
Description
•