1822301 - Clear Sources content reducer on each target/thread removal

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Similarly to bug 1814177, sources content reducer should be clearer per target/thread removal in order to avoid sources text content when pausing during unload event.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822301 - [devtools] Compute source and source actor objects to be removed from actions.

In order to properly clear all reducers when thread is removed,
it is helpful to compute the list of source and source actor objects
alongside the REMOVE_THREAD action.

It is especially important for source objects which aren't bound to
any particular thread and are only cleared once all thread stopped
refering to a particular shared source url.
The list of source objects to be removed can only be computed based
on sources.js reducer data.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822301 - [devtools] Clear sources-content reducer on each thread removal.

This help reduce the memory footprint when a target is removed, especially in the browser toolbox.
And it will help stop clearing the whole state on navigation.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822301 - [devtools] Use location's source and sourceActor from sources-content selectors.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822301 - [devtools] Store source actor objects in sources reducer's actors map.

Instead of storing a subset of attributes, it would drastically simplify things
to store the source actors objects. These objects are immutable so it is safe
to store them into the reducer.
It will prevent having to do many ID to object lookup!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84473d29f48a
[devtools] Store source actor objects in sources reducer's actors map. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/bb6bd39b293c
[devtools] Compute source and source actor objects to be removed from actions. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/7e211af17b37
[devtools] Clear sources-content reducer on each thread removal. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/4b3a4ca27c4f
[devtools] Use location's source and sourceActor from sources-content selectors. r=devtools-reviewers,nchevobbe

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/84473d29f48a
https://hg.mozilla.org/mozilla-central/rev/bb6bd39b293c
https://hg.mozilla.org/mozilla-central/rev/7e211af17b37
https://hg.mozilla.org/mozilla-central/rev/4b3a4ca27c4f