Closed Bug 1822302 Opened 1 year ago Closed 1 year ago

Clear breakable lines and positions in sources reducer on each target/thread removal

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(4 files)

Similarly to bug 1814177, breakable lines and positions in the sources reducer should be clearer per target/thread removal in order to avoid breaking breakpoints when pausing during unload event.

This reducer clears itself almost correctly on thread removal, except for breakable lines and positions attributes.

We only expose the values of this map out of selectors, so there is no need
to clone this large map on every change.

We mostly expose the values of this map out of selectors, so there is no need
to clone this large map on every change.
We were only using the map in visible column breakpoint,
but this wasn't justified the cost of cloning the map.

Now that these maps are mutable, and we pass the list of sources to be removed,
it is trivial to clear the maps.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92c23de6c349
[devtools] Use mutable map for original source breakable lines. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/dec5a35facab
[devtools] Use mutable map for breakpoint positions. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0117e48037b8
[devtools] Clear breakable lines and positions on target removal. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/146ffef0d825
[devtools] Sort sources state object alphabetically. r=devtools-reviewers,nchevobbe
Regressions: 1832563
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: