Clear breakable lines and positions in sources reducer on each target/thread removal
Categories
(DevTools :: Debugger, task)
Tracking
(firefox114 fixed)
Tracking | Status | |
---|---|---|
firefox114 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Similarly to bug 1814177, breakable lines and positions in the sources reducer should be clearer per target/thread removal in order to avoid breaking breakpoints when pausing during unload event.
This reducer clears itself almost correctly on thread removal, except for breakable lines and positions attributes.
Assignee | ||
Comment 1•2 months ago
|
||
We only expose the values of this map out of selectors, so there is no need
to clone this large map on every change.
Assignee | ||
Comment 2•2 months ago
|
||
We mostly expose the values of this map out of selectors, so there is no need
to clone this large map on every change.
We were only using the map in visible column breakpoint,
but this wasn't justified the cost of cloning the map.
Assignee | ||
Comment 3•2 months ago
|
||
Now that these maps are mutable, and we pass the list of sources to be removed,
it is trivial to clear the maps.
Updated•2 months ago
|
Assignee | ||
Comment 4•2 months ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92c23de6c349 [devtools] Use mutable map for original source breakable lines. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/dec5a35facab [devtools] Use mutable map for breakpoint positions. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/0117e48037b8 [devtools] Clear breakable lines and positions on target removal. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/146ffef0d825 [devtools] Sort sources state object alphabetically. r=devtools-reviewers,nchevobbe
Comment 6•1 month ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/92c23de6c349
https://hg.mozilla.org/mozilla-central/rev/dec5a35facab
https://hg.mozilla.org/mozilla-central/rev/0117e48037b8
https://hg.mozilla.org/mozilla-central/rev/146ffef0d825
Description
•