1822302 - Clear breakable lines and positions in sources reducer on each target/thread removal

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Similarly to bug 1814177, breakable lines and positions in the sources reducer should be clearer per target/thread removal in order to avoid breaking breakpoints when pausing during unload event.

This reducer clears itself almost correctly on thread removal, except for breakable lines and positions attributes.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822302 - [devtools] Use mutable map for original source breakable lines.

We only expose the values of this map out of selectors, so there is no need
to clone this large map on every change.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822302 - [devtools] Use mutable map for breakpoint positions.

We mostly expose the values of this map out of selectors, so there is no need
to clone this large map on every change.
We were only using the map in visible column breakpoint,
but this wasn't justified the cost of cloning the map.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822302 - [devtools] Clear breakable lines and positions on target removal.

Now that these maps are mutable, and we pass the list of sources to be removed,
it is trivial to clear the maps.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822302 - [devtools] Sort sources state object alphabetically.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92c23de6c349
[devtools] Use mutable map for original source breakable lines. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/dec5a35facab
[devtools] Use mutable map for breakpoint positions. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0117e48037b8
[devtools] Clear breakable lines and positions on target removal. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/146ffef0d825
[devtools] Sort sources state object alphabetically. r=devtools-reviewers,nchevobbe

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/92c23de6c349
https://hg.mozilla.org/mozilla-central/rev/dec5a35facab
https://hg.mozilla.org/mozilla-central/rev/0117e48037b8
https://hg.mozilla.org/mozilla-central/rev/146ffef0d825