1822303 - Clear expanded and focusedItem in source-tree reducer on each target/thread removal

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Similarly to bug 1814177, expanded and focusedItem in the source-tree reducer should be clearer per target/thread removal in order to avoid breaking the source tree when pausing during unload event.

This reducer clears itself almost correctly on thread removal, except for expanded Set and focusedItem attribute.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822303 - [devtools] Avoid unecessary clone of expanded Set.

This data is only used by the SourcesTree and updated by it,
so it rather ought to be a local state.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822303 - [devtools] Stop duplicating expanded state between SourcesTree and ManagedTree.

The expanded props on SourcesTree duplicates the same props of ManagedTree, with no added value.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822303 - [devtools] Migrate SourcesTree focused item from redux to react state.

This data is only used by the SourcesTree and updated by it,
so it rather ought to be a local state.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822303 - [devtools] Remove unused Tree.itemHeight attribute.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822303 - [devtools] Update expanded and focusedItem from the reducer on selected location change.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9c70fd7098a
[devtools] Remove unused Tree.itemHeight attribute. r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/8ae166d3e0de
[devtools] Update expanded and focusedItem from the reducer on selected location change. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a153c166d656
[devtools] Avoid unecessary clone of expanded Set. r=devtools-reviewers,nchevobbe

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c9c70fd7098a
https://hg.mozilla.org/mozilla-central/rev/8ae166d3e0de
https://hg.mozilla.org/mozilla-central/rev/a153c166d656