1822306 - additional permission popup not showing specified extension icon

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect, P3)

Description

[Hari Naaraayanan]

Attachment: additional-permission-popup.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36

Steps to reproduce:

I am building an extension where i have added optional permission for "topsites". I have specified required extension icons in manifest ,it is showing properly in toolbar and in other places like extension page, but in additional permission popup it is not showing my extension icon, but it is showing default icon.
icons are specified in manifest as below ,

{
"icons" : {
"16": "icon-16.png",
"32": "icon-32.png",
"64": "icon-64.png"
},
"optional_permissions" : ["topsites"],
"browser_action": {
"default_icon": {
"16": "icon-16,png",
"32": "icon-32.png",
"64": "icon-64.png"
}
}
}

Actual results:

In additional permission popup it is showing default extension icon.

Expected results:

In additional permission popup extension icon which i specified has to be shown when its prompted to user.

Comment 1

[Hari Naaraayanan]

Attachment: additional-permission--popup.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[vcarciu]

Can you please attach the addon used in order to try to reproduce the issue on our side?

Thanks,
Victor

Comment 4

[Hari Naaraayanan]

Attachment: permissions-addon.zip

extension file attached

Comment 5

[vcarciu]

Hello,

Thanks for the attachment.
I was able to reproduce the described issue so I am marking it as NEW for more investigations.

Thank you ,
Victor

Comment 6

[William Durand [:willdurand] [OOO until Aug. 25]]

Looks like this never worked? I can also reproduce. The code looks a bit odd, it seems we call context.extension.iconURL, which is not a thing.

Comment 7

[William Durand [:willdurand] [OOO until Aug. 25]]

Attachment: Bug 1822306 - Add `Extension.getPreferredIcon()` method and use it. r?zombie!

It looks like extension.iconURL never worked. I added a getPreferredIcon()
that relies on IconDetails.getPreferredIcon() under the hood in order to
easily get icon URLs from an instance of an Extension. I updated a few places
where using this new method is a bit better.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47ac8fb37606
Add `Extension.getPreferredIcon()` method and use it. r=zombie

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/47ac8fb37606

Comment 10

[vcarciu]

Verified as fixed in latest FF 113.
Please see attached screenshots.

Comment 11

[vcarciu]

Attachment: Postfix screenshot

Comment 12

[Hari Naaraayanan]

Thanks for the fix, I will verify it.