1822307 - Clear highlightedLineRange in UI reducer on each target/thread removal

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Similarly to bug 1814177, highlightedLineRange in the UI reducer should be clearer per target/thread removal in order to avoid breaking the source tree when pausing during unload event.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822307 - [devtools] Clear highlightedLineRange on thread removal.

This data is transient so it isn't super critical to clear it,
but let's do it for consistancy between all the reducers.

While doing this:

• clarify this attribute with jsdocs
• use null as default value
• avoid unecessary state change

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822307 - [devtools] Make QuickOpenModal more explicitly clear highlight ranges.

It isn't super clear when item.location can be null,
but it looks overall simplier and clearer to use the two distinct actions from the React component.

Also note that the call to highlightLineRange was missing the sourceId attribute,
which will be important for the next changeset.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1822307 - [devtools] Ensure checking highlightedLineRange's related source.

We were not reading highlightedLineRange's sourceId
and so we might have been highlighting the wrong lines.

Move some logic up to Editor/index which knows about the displayed source.
This also help completely disable the HighlightedLines component until
an highlights start.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dba44dab8dbf
[devtools] Clear highlightedLineRange on thread removal. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/7fa8b9418b7d
[devtools] Make QuickOpenModal more explicitly clear highlight ranges. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/169195adc869
[devtools] Ensure checking highlightedLineRange's related source. r=devtools-reviewers,nchevobbe

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dba44dab8dbf
https://hg.mozilla.org/mozilla-central/rev/7fa8b9418b7d
https://hg.mozilla.org/mozilla-central/rev/169195adc869