Closed Bug 1822398 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38996 - [rsafor] Rename requestStorageAccessForOrigin to requestStorageAccessFor

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox113 fixed)

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38996 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38996
Details from upstream follow.

Matt Reichhoff <mreichhoff@chromium.org> wrote:

[rsafor] Rename requestStorageAccessForOrigin to requestStorageAccessFor

This allows for evolution of the scope of the permission without
requiring deprecation of the old name.

Change-Id: Iee11f56a41ec116b800515adaf4ee3fe7fc91e26
Bug: 1424452
Reviewed-on: https://chromium-review.googlesource.com/4337982
WPT-Export-Revision: 0bc30b460ae9c9d9db40fc38dfca0f4d0bf18fdb

PR 38996 applied with additional changes from upstream: b8b076a080a4b1237b3a571e2f465085cca96a2e

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 13 subtests

Status Summary

Firefox

OK : 1
FAIL : 8[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] 9[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
ERROR : 1
NOTRUN: 9[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] 11[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]

Chrome

OK : 1
FAIL : 18
ERROR : 1
NOTRUN: 2

Safari

OK : 1
FAIL : 8
ERROR : 1
NOTRUN: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /top-level-storage-access-api/tentative/requestStorageAccessFor-insecure.sub.window.html [wpt.fyi]
    • [insecure-context] document.requestStorageAccessFor() should be supported on the document interface: FAIL (Chrome: FAIL, Safari: FAIL)
    • [insecure-context] document.requestStorageAccessFor() should be rejected by default with no user gesture: FAIL (Chrome: FAIL, Safari: FAIL)
    • [non-fully-active] document.requestStorageAccessFor() should not resolve when run in a detached frame: FAIL (Chrome: FAIL, Safari: FAIL)
    • [non-fully-active] document.requestStorageAccessFor() should not resolve when run in a detached DOMParser document: FAIL (Chrome: FAIL, Safari: FAIL)
    • [insecure-context] document.requestStorageAccessFor() should be rejected when called in an insecure context: FAIL (Chrome: FAIL, Safari: FAIL)
    • [frame-on-insecure-page] document.requestStorageAccessFor() should be supported on the document interface: FAIL (Chrome: FAIL, Safari: FAIL)
    • [frame-on-insecure-page] document.requestStorageAccessFor() should be rejected when called in an iframe: FAIL (Chrome: FAIL, Safari: FAIL)
  • /top-level-storage-access-api/tentative/requestStorageAccessFor.sub.https.window.html [wpt.fyi]: ERROR (Chrome: ERROR, Safari: ERROR)
    • [top-level-context] document.requestStorageAccessFor() should be supported on the document interface: FAIL (Chrome: FAIL, Safari: FAIL)
    • [top-level-context] document.requestStorageAccessFor() should be rejected when called with no argument: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [top-level-context] document.requestStorageAccessFor() should be rejected by default with no user gesture: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [non-fully-active] document.requestStorageAccessFor() should not resolve when run in a detached frame: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [non-fully-active] document.requestStorageAccessFor() should not resolve when run in a detached DOMParser document: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [top-level-context] document.requestStorageAccessFor() should be resolved without a user gesture with an existing permission: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [top-level-context] document.requestStorageAccess() should be resolved without a user gesture after a successful requestStorageAccessFor() call: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [top-level-context] document.requestStorageAccessFor() should be resolved when called properly with a user gesture and the same site: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [top-level-context] document.requestStorageAccessFor() should be rejected when called with an invalid site: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [top-level-context] document.requestStorageAccessFor() should be rejected when called with an opaque origin: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
    • [same-origin-frame] document.requestStorageAccessFor() should be supported on the document interface: FAIL (Chrome: FAIL)
    • [same-origin-frame] document.requestStorageAccessFor() should be rejected when called with no argument: NOTRUN (Chrome: NOTRUN)
    • [same-origin-frame] document.requestStorageAccessFor() should be rejected when called in an iframe: NOTRUN (Chrome: NOTRUN)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c689013eb7f [wpt PR 38996] - [rsafor] Rename requestStorageAccessForOrigin to requestStorageAccessFor, a=testonly https://hg.mozilla.org/integration/autoland/rev/d706318c565f [wpt PR 38996] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4c689013eb7f
https://hg.mozilla.org/mozilla-central/rev/d706318c565f

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.