Closed Bug 1822476 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39005 - [@scope] Enable nesting features within @scope's body

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39005 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39005
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@scope] Enable nesting features within @scope's body

This CL passes a parent rule and accompanying CSSNestingType
to the ConsumeRuleList call which handles @scope's body. This has
the following effects:

  • A :scope descendant compound is implicitly inserted if the selector
    is not scope-containing.
  • The parent selector (&) now refers to the \<scope-start>
    selector list.
  • Relative selectors are enabled.

This CL also introduces a slightly more advanced scope guard for
cleaning up the arena: the new ArenaGuard ensures that the arena is
cleaned even if there is no outer call to ConsumeStyleRule with
parent_rule_for_nesting==nullptr.

Bug: 1280240
Change-Id: Ibe6b1e40e22d535a094b0ec464ae119952b015f5
Reviewed-on: https://chromium-review.googlesource.com/4272459
WPT-Export-Revision: d242d0b05e9d30d70f5f874ba66b3300299322bb

PR 39005 applied with additional changes from upstream: a823469856631666460fc713b552103450a70710, 7c083dd76a0a8d9eb1e5a320fa6a2335d058ce34
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Severity: -- → S4
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/29d28cfda09a [wpt PR 39005] - [@scope] Enable nesting features within @scope's body, a=testonly https://hg.mozilla.org/integration/autoland/rev/1d8838822136 [wpt PR 39005] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/29d28cfda09a
https://hg.mozilla.org/mozilla-central/rev/1d8838822136

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.