1822548 - Missing media controls, including Picture-in-Picture (PiP) controls

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Blake]

Attachment: YouTube.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

Major sites such as Reddit, Youtube, and Twitch's video players are missing control buttons.

Comment 1

[Blake]

Mozregression points to Bug 1804291

Comment 2

[:gerard-majax]

(In reply to Blake from comment #1)

Mozregression points to Bug 1804291

Care to share it?

Comment 3

[:gerard-majax]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c4ea1b02963a6460e7e08038e1906133d2ffcd96&tochange=3a01b3eaabf2ecd31c5922eb26d7b470b47baa91

Comment 4

[Blake]

(In reply to Alexandre LISSY :gerard-majax from comment #2)

(In reply to Blake from comment #1)

Mozregression points to Bug 1804291

Care to share it?

Is there an easy way to share it, do you want a specific section or just the entire raw json file?

Comment 5

[:gerard-majax]

(In reply to Blake from comment #4)

(In reply to Alexandre LISSY :gerard-majax from comment #2)

(In reply to Blake from comment #1)

Mozregression points to Bug 1804291

Care to share it?

Is there an easy way to share it, do you want a specific section or just the entire raw json file?

mozregression gets you a link to a pushlog, as I shared earlier, which points to my patches (that are not supposed to be close whatsoever to content) and a gfx change that is about simplification ...

Comment 6

[:gerard-majax]

Alice, do you mind sharing a bit what is happening here? I'm investigating the issue, it would be nice to know if you have rather identified something useful ...

Comment 7

[:gerard-majax]

So for clarification, a local revert of bug 1821233 indeed fixes the issue.

Comment 8

[Alice0775 White]

FWIW,
On local video(file://), no progress seeking thumb/volume thumb are displayed.
In this case, removing css filter for .volumeControl::-moz-range-thumb, .scrubber::-moz-range-thumb displays the thumb.

On Youtube video, if setting opacity:1.0 instead 0.9 then the control buttons are displayed.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

:gw, since you are the author of the regressor, bug 1821233, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Bug 1821233 has been backed out and Nightly respins will be started shortly.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

New nightly builds are available with the fix now.

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-03-15 Nightly build on Windows 10.
Verified as fixed on Firefox 113.0b9(build ID: 20230427175833) and Nightly 114.0a1(build ID: 20230428092401) on Windows 10, macOS 12, Ubuntu 22.