Closed Bug 1822566 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39015 - Revert "Another attempt to deflake loaf tests"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox113 fixed)

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39015 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39015
Details from upstream follow.

Leonard Grey <lgrey@chromium.org> wrote:

Revert "Another attempt to deflake loaf tests"

This reverts commit 74740d551f6177ad983ce0d561af9efbc2994edd.

Reason for revert: Consistently failing on mac11-arm64-rel-tests since this landed. First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/15338/overview

Original change's description:

Another attempt to deflake loaf tests

Relax time comparisons to have a ~5ms approximation

Bug: 1422630
Change-Id: I48cd3287bba98a91c6c820093ee80880657349c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334367
Reviewed-by: Yoav Weiss \<yoavweiss@chromium.org>
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117460}

Bug: 1422630
Change-Id: Ic9f796874331877db6a2604c0fc13e2b6f1a40ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340611
Commit-Queue: Leonard Grey \<lgrey@chromium.org>
Owners-Override: Leonard Grey \<lgrey@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1117478}

PR 39015 applied with additional changes from upstream: b8e9469a49469720bb72a078c4ecde798daa70f5, d3027dd4e2fce8faa493ea0b9e6bd6507cf8651e, 6da14f4d97d5ee017f6876cc10a8469e5d8839bb, fc39740db1b060bcb59c5252ab10156a37c105fa

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 4 subtests

Status Summary

Firefox

ERROR : 12[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 13[GitHub]

Chrome

OK : 11
PASS : 15
FAIL : 27
TIMEOUT: 1
ERROR : 2
NOTRUN : 3

Safari

ERROR : 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9efb8241be5c [wpt PR 39015] - Revert "Another attempt to deflake loaf tests", a=testonly

https://hg.mozilla.org/mozilla-central/rev/9efb8241be5c

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.