Closed Bug 1822590 Opened 2 years ago Closed 2 years ago

touching a single moz.build file drastically increases the build time after Bug 1820189 landed

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox-esr102 unaffected, firefox111 unaffected, firefox112 fixed, firefox113 fixed)

RESOLVED DUPLICATE of bug 1820334
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- fixed
firefox113 --- fixed

People

(Reporter: mjf, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Changes from Bug 1820189 cause the build times to increase by 10x on my machine when touching any moz.build file. I've verified that removing the patches from 1820189 restores the previous build behavior. I've also verified that Bug 1821463 landing did not remedy the issue.

Some data for example (all times are for comparison on the same machine with a pre-warmed ccache):
With Bug 1820189:
touch a moz.build file - 4m4s

Without Bug 1820189:
touch a moz.build file - 0m24s

Keywords: regression
Regressed by: 1820189
Blocks: 1822194

Set release status flags based on info from the regressing bug 1820189

:chutten, since you are the author of the regressor, bug 1820189, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

As a note of explanation, when we're running the libwebrtc fast-forward process to update between chromium milestones, we import approximately 300 commits from upstream and each of the those vendored commits touches (but doesn't always modify) moz.build files. Under normal processing, our scripting handles about 1 upstream commit per minute (including a build). A build time increase to 3-4 minutes for the 300 upstream commits represents a significant quality-of-life change.

This is probably related to bug 1820334.

Duplicate of this bug: 1821753

(In reply to Mike Hommey [:glandium] from comment #3)

This is probably related to bug 1820334.

It totally is.

Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1820334
Resolution: --- → DUPLICATE
Flags: needinfo?(chutten)
You need to log in before you can comment on or make changes to this bug.