1822675 - Enqueuing on piped ReadableStream causes synchronous write, while not in Blink/WebKit

Status: RESOLVED FIXED

(Core :: DOM: Streams, defect)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

var con;
new ReadableStream({ start(c) { con = c }}, { highWaterMark: 0 }).pipeTo(
  new WritableStream({ write(chunk, c) { console.log(chunk, 'write') } })
)
await Promise.resolve();
con.enqueue('hi');
console.log('hello');

This emits "hello" first on WebKit/Blink but emits "hi write" first on Gecko.

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1822675 - Part 1: Call write asynchronously from PipeToPump r=smaug

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 1822675 - Part 2: Do not reject with uncatchable exception r=smaug

https://wpt.live/encoding/streams/stringification-crash.html crashes again without this.

Depends on D172794

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b5413c6adaf
Part 1: Call write asynchronously from PipeToPump r=smaug
https://hg.mozilla.org/integration/autoland/rev/f280bc1b1080
Part 2: Do not reject with uncatchable exception r=smaug

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39103 for changes under testing/web-platform/tests

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8b5413c6adaf
https://hg.mozilla.org/mozilla-central/rev/f280bc1b1080

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot