Closed
Bug 1822687
Opened 2 years ago
Closed 2 years ago
Github push hook couldn't mark bug 1822283 after the PR merged
Categories
(bugzilla.mozilla.org :: API, defect)
bugzilla.mozilla.org
API
Tracking
()
RESOLVED
FIXED
People
(Reporter: RyanVM, Unassigned)
References
Details
I'm going to guess it has to do with what flags are available for marking in the Glean SDK component.
Payload:
{
"ref": "refs/heads/main",
"before": "af4996986ae3c23484f6543d221492f1498749db",
"after": "02aff5d8064389092835f5e93b9d623fe5f45103",
"repository": {
"id": 518992906,
"node_id": "R_kgDOHu80Cg",
"name": "firefox-android",
"full_name": "mozilla-mobile/firefox-android",
"private": false,
"owner": {
"name": "mozilla-mobile",
"email": null,
"login": "mozilla-mobile",
"id": 22351667,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3",
"avatar_url": "https://avatars.githubusercontent.com/u/22351667?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mozilla-mobile",
"html_url": "https://github.com/mozilla-mobile",
"followers_url": "https://api.github.com/users/mozilla-mobile/followers",
"following_url": "https://api.github.com/users/mozilla-mobile/following{/other_user}",
"gists_url": "https://api.github.com/users/mozilla-mobile/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mozilla-mobile/subscriptions",
"organizations_url": "https://api.github.com/users/mozilla-mobile/orgs",
"repos_url": "https://api.github.com/users/mozilla-mobile/repos",
"events_url": "https://api.github.com/users/mozilla-mobile/events{/privacy}",
"received_events_url": "https://api.github.com/users/mozilla-mobile/received_events",
"type": "Organization",
"site_admin": false
},
"html_url": "https://github.com/mozilla-mobile/firefox-android",
"description": "This repository hosts the Firefox for Android (Fenix), Focus for Android, and Mozilla Android Components projects.",
"fork": false,
"url": "https://github.com/mozilla-mobile/firefox-android",
"forks_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/forks",
"keys_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/keys{/key_id}",
"collaborators_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/collaborators{/collaborator}",
"teams_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/teams",
"hooks_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/hooks",
"issue_events_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/issues/events{/number}",
"events_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/events",
"assignees_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/assignees{/user}",
"branches_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/branches{/branch}",
"tags_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/tags",
"blobs_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/git/blobs{/sha}",
"git_tags_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/git/tags{/sha}",
"git_refs_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/git/refs{/sha}",
"trees_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/git/trees{/sha}",
"statuses_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/statuses/{sha}",
"languages_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/languages",
"stargazers_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/stargazers",
"contributors_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/contributors",
"subscribers_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/subscribers",
"subscription_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/subscription",
"commits_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/commits{/sha}",
"git_commits_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/git/commits{/sha}",
"comments_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/comments{/number}",
"issue_comment_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/issues/comments{/number}",
"contents_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/contents/{+path}",
"compare_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/compare/{base}...{head}",
"merges_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/merges",
"archive_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/{archive_format}{/ref}",
"downloads_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/downloads",
"issues_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/issues{/number}",
"pulls_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/pulls{/number}",
"milestones_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/milestones{/number}",
"notifications_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/notifications{?since,all,participating}",
"labels_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/labels{/name}",
"releases_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/releases{/id}",
"deployments_url": "https://api.github.com/repos/mozilla-mobile/firefox-android/deployments",
"created_at": 1659041943,
"updated_at": "2023-03-15T16:27:18Z",
"pushed_at": 1678909776,
"git_url": "git://github.com/mozilla-mobile/firefox-android.git",
"ssh_url": "git@github.com:mozilla-mobile/firefox-android.git",
"clone_url": "https://github.com/mozilla-mobile/firefox-android.git",
"svn_url": "https://github.com/mozilla-mobile/firefox-android",
"homepage": "https://www.mozilla.org/en-us/firefox/mobile/",
"size": 403440,
"stargazers_count": 343,
"watchers_count": 343,
"language": "Kotlin",
"has_issues": false,
"has_projects": true,
"has_downloads": true,
"has_wiki": false,
"has_pages": true,
"has_discussions": false,
"forks_count": 119,
"mirror_url": null,
"archived": false,
"disabled": false,
"open_issues_count": 81,
"license": {
"key": "mpl-2.0",
"name": "Mozilla Public License 2.0",
"spdx_id": "MPL-2.0",
"url": "https://api.github.com/licenses/mpl-2.0",
"node_id": "MDc6TGljZW5zZTE0"
},
"allow_forking": true,
"is_template": false,
"web_commit_signoff_required": false,
"topics": [
],
"visibility": "public",
"forks": 119,
"open_issues": 81,
"watchers": 343,
"default_branch": "main",
"stargazers": 343,
"master_branch": "main",
"organization": "mozilla-mobile"
},
"pusher": {
"name": "rvandermeulen",
"email": "ryanvm@gmail.com"
},
"organization": {
"login": "mozilla-mobile",
"id": 22351667,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3",
"url": "https://api.github.com/orgs/mozilla-mobile",
"repos_url": "https://api.github.com/orgs/mozilla-mobile/repos",
"events_url": "https://api.github.com/orgs/mozilla-mobile/events",
"hooks_url": "https://api.github.com/orgs/mozilla-mobile/hooks",
"issues_url": "https://api.github.com/orgs/mozilla-mobile/issues",
"members_url": "https://api.github.com/orgs/mozilla-mobile/members{/member}",
"public_members_url": "https://api.github.com/orgs/mozilla-mobile/public_members{/member}",
"avatar_url": "https://avatars.githubusercontent.com/u/22351667?v=4",
"description": "Mozilla Mobile Applications"
},
"enterprise": {
"id": 6981,
"slug": "mozilla-corporation",
"name": "Mozilla-Corporation",
"node_id": "MDEwOkVudGVycHJpc2U2OTgx",
"avatar_url": "https://avatars.githubusercontent.com/b/6981?v=4",
"description": null,
"website_url": null,
"html_url": "https://github.com/enterprises/mozilla-corporation",
"created_at": "2021-05-04T21:26:07Z",
"updated_at": "2023-03-10T20:33:05Z"
},
"sender": {
"login": "rvandermeulen",
"id": 3661247,
"node_id": "MDQ6VXNlcjM2NjEyNDc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3661247?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rvandermeulen",
"html_url": "https://github.com/rvandermeulen",
"followers_url": "https://api.github.com/users/rvandermeulen/followers",
"following_url": "https://api.github.com/users/rvandermeulen/following{/other_user}",
"gists_url": "https://api.github.com/users/rvandermeulen/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rvandermeulen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rvandermeulen/subscriptions",
"organizations_url": "https://api.github.com/users/rvandermeulen/orgs",
"repos_url": "https://api.github.com/users/rvandermeulen/repos",
"events_url": "https://api.github.com/users/rvandermeulen/events{/privacy}",
"received_events_url": "https://api.github.com/users/rvandermeulen/received_events",
"type": "User",
"site_admin": false
},
"created": false,
"deleted": false,
"forced": false,
"base_ref": null,
"compare": "https://github.com/mozilla-mobile/firefox-android/compare/af4996986ae3...02aff5d80643",
"commits": [
{
"id": "02aff5d8064389092835f5e93b9d623fe5f45103",
"tree_id": "9fd5e7b771b4582e2e9b75b109c69d642dfa4002",
"distinct": true,
"message": "Bug 1822283 - Fix race condition for Ad IDs\n\nThere is a race condition with generated hashed Ad IDs because we were\nusing a single metric rather than separate metrics for each. We use this\nnew metric so we can send a differently salted version of the ad ID in\ntwo separate pings.",
"timestamp": "2023-03-15T15:49:36-04:00",
"url": "https://github.com/mozilla-mobile/firefox-android/commit/02aff5d8064389092835f5e93b9d623fe5f45103",
"author": {
"name": "Bruno Rosa",
"email": "rosahbruno@gmail.com",
"username": "rosahbruno"
},
"committer": {
"name": "Ryan VanderMeulen",
"email": "ryanvm@gmail.com",
"username": "rvandermeulen"
},
"added": [
],
"removed": [
],
"modified": [
"fenix/app/metrics.yaml",
"fenix/app/src/main/java/org/mozilla/fenix/components/metrics/clientdeduplication/ClientDeduplicationPing.kt"
]
}
],
"head_commit": {
"id": "02aff5d8064389092835f5e93b9d623fe5f45103",
"tree_id": "9fd5e7b771b4582e2e9b75b109c69d642dfa4002",
"distinct": true,
"message": "Bug 1822283 - Fix race condition for Ad IDs\n\nThere is a race condition with generated hashed Ad IDs because we were\nusing a single metric rather than separate metrics for each. We use this\nnew metric so we can send a differently salted version of the ad ID in\ntwo separate pings.",
"timestamp": "2023-03-15T15:49:36-04:00",
"url": "https://github.com/mozilla-mobile/firefox-android/commit/02aff5d8064389092835f5e93b9d623fe5f45103",
"author": {
"name": "Bruno Rosa",
"email": "rosahbruno@gmail.com",
"username": "rosahbruno"
},
"committer": {
"name": "Ryan VanderMeulen",
"email": "ryanvm@gmail.com",
"username": "rvandermeulen"
},
"added": [
],
"removed": [
],
"modified": [
"fenix/app/metrics.yaml",
"fenix/app/src/main/java/org/mozilla/fenix/components/metrics/clientdeduplication/ClientDeduplicationPing.kt"
]
}
}
Response:
{"code":-32000,"documentation":"https:\/\/bmo.readthedocs.io\/en\/latest\/api\/","error":1,"message":"Some flags do not belong to bug 1822283."}
Flags: needinfo?(dkl)
|
Reporter | |
Comment 1•2 years ago
|
||
If the issue is the lack of Milestone flags in that product, I'd would say that we can just skip setting it.
|
||
Comment 2•2 years ago
|
||
It was due to the qe-verify flag not being enabled for Data and Platform Tools which I have fixed. I am tempted to enable that flag for all products in Bugzilla. You hit redeliver in the webhook activity tab in Github and it will close that bug if you like.
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(dkl)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•