1822697 - Temporarily disable extra profiler run on benchmarks

Status: RESOLVED FIXED

(Testing :: Performance, defect, P1)

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

:sparky wanted to clarify your comment
https://bugzilla.mozilla.org/show_bug.cgi?id=1809652#c21

you suggested decreasing proc_timeout to 7 minutes, however depending on the bench mark it seems to usually be under 7 minutes anyway. Did you mean a different time out?

or if you did indeed mean proc_timeout, maybe we can use the (existing proc_timeout for that benchmark)/2 or something like that

Comment 2

[Greg Mierzwinski [:sparky]]

I think we might want to rethink how we fix this given the issue from bug 1821783. This kind of comes back to what I said about the extra_profiler_run step not being built for benchmark tests. What we'll need to do here is re-implement the logic for benchmarks, and separate it from the pageload test logic for the extra run. You could also disable the extra-profiler-run in the benchmarks for now until we implement the proper methodology.

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

Thanks for clarifying. Good point
And I think I will go ahead and disable this temporarily

Comment 4

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1822697 - Temporarily disable extra profiler runs on Benchmark tests in CI. r?#perftest

This patch temporarily removes the --extra-profiler-run flag from the Browsertime Benchmark tests in CI.
Originally the logic was intended for pageload tests. Currently it is causing some issues (intermittent failures and useless profiles for benchmarks)
so in the mean time we can disable it before spending time on fixing the implementation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de00b51e1339
Temporarily disable extra profiler runs on Benchmark tests in CI. r=perftest-reviewers,sparky

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/de00b51e1339