Closed
Bug 1822779
Opened 1 year ago
Closed 1 year ago
[wdspec] Remove tentative suffix from "script.addPreloadScript" and "script.removePreloadScript" tests
Categories
(Remote Protocol :: WebDriver BiDi, task, P1)
Remote Protocol
WebDriver BiDi
Tracking
(firefox113 fixed)
RESOLVED
FIXED
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: whimboo, Assigned: Sasha)
References
()
Details
(Whiteboard: [webdriver:m6], [wptsync upstream])
Attachments
(1 file)
We are going to change the script.addPreloadScript so that it no longer takes an expression but a function as argument. The relevant work is covered by the following Webdriver BiDi Pull:
https://github.com/w3c/webdriver-bidi/pull/381
Depending on when it lands we should do a quick follow-up and update our implementation and tests. So it will be a M6 or M7 related bug.
|
Assignee | |
Comment 1•1 year ago
|
||
Actually, our implementation already takes a function as an argument. But as soon as the spec PR is merged, we can remove tentative postfix from wdspec test file names.
|
Reporter | |
Comment 2•1 year ago
|
||
Good point. I forgot that and should have checked. Nevertheless that gives me lesser worry regarding backward incompatibility. I'm going to update the summary accordingly.
Summary: "script.addPreloadScript" should take a function declaration instead of expression → [wdspc] Remove tentative suffix from "script.addPreloadScript" tests
|
|
Reporter | |
Updated•1 year ago
|
Points: --- → 1
Priority: -- → P2
Whiteboard: [webdriver:backlog]
|
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•1 year ago
|
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m6]
|
|
Reporter | |
Updated•1 year ago
|
Blocks: 1806421
Summary: [wdspc] Remove tentative suffix from "script.addPreloadScript" tests → [wdspc] Remove tentative suffix from "script.addPreloadScript" and "script.removePreloadScript" tests
|
|
Assignee | |
Comment 3•1 year ago
|
||
|
|
Assignee | |
Updated•1 year ago
|
Summary: [wdspc] Remove tentative suffix from "script.addPreloadScript" and "script.removePreloadScript" tests → [wdspec] Remove tentative suffix from "script.addPreloadScript" and "script.removePreloadScript" tests
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f3e5ea7e15f [wdspec] Remove tentative suffix from "script.addPreloadScript" and "script.removePreloadScript" tests. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39335 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m6] → [webdriver:m6], [wptsync upstream]
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in
before you can comment on or make changes to this bug.
Description
•