1822842 - Allow to enable and disable Windows-native notification Windows Event Log messages

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P3)

Description

[Greg Stoll :gstoll]

Attachment: notification event log.png

This was reported on Reddit, and I see it on the latest nightly.

I've attached a screenshot, and here are the details from one of the events:

Log Name: Application
Source: Firefox Nightly Notification Server
Date: 3/16/2023 9:00:07 AM
Event ID: 0
Task Category: None
Level: Error
Keywords: Classic
User: N/A
Computer: DESKTOP-2J49KLU
Description:
The operation completed successfully.
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
<System>
<Provider Name="Firefox Nightly Notification Server" />
<EventID Qualifiers="0">0</EventID>
<Version>0</Version>
<Level>2</Level>
<Task>0</Task>
<Opcode>0</Opcode>
<Keywords>0x80000000000000</Keywords>
<TimeCreated SystemTime="2023-03-16T14:00:07.1472524Z" />
<EventRecordID>36989</EventRecordID>
<Correlation />
<Execution ProcessID="46020" ThreadID="0" />
<Channel>Application</Channel>
<Computer>DESKTOP-2J49KLU</Computer>
<Security />
</System>
<EventData>
<Data>Error: Pipe write succeeded! (HandlePipeMessages:231)</Data>
</EventData>
</Event>

Comment 1

[Greg Stoll :gstoll]

I should note that the notifications seem to display just fine for me, so that's not a problem.

Comment 2

[Nick Alexander :nalexander [he/him]]

Yeah, this was oversight on our (the implementors) parts: we dump some debug logging to the Windows Event Log and didn't implement a log level. I'll turn this ticket into that.

Technically, I think this will want to be a per-installation Windows registry entry that sets the log level. The log level should default to only logging errors.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1781929

Comment 4

[Nick Rishel [:nrishel]]

:nalexander we only log on notification invocation. A quick and easy way to implement this would be an about:config log level that gets passed along as an argument to the notification.

Comment 5

[Nick Rishel [:nrishel]]

Attachment: Bug 1822842 - Trim down notification server event viewer logging unless `alerts.useSystemBackend.windows.notificationserver.verbose=true`. r=nalexander

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Nick, could you set a severity on this bug? Looks late for 111, what do we want to do with this issue for 112?

Comment 7

[Nick Rishel [:nrishel]]

This has minor impact on users aside from mild confusion if checking through the event viewer. Changes are trivial to audit so probably a good beta uplift candidate since we're still making a mess?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7544895e82c1
Trim down notification server event viewer logging unless `alerts.useSystemBackend.windows.notificationserver.verbose=true`. r=nalexander

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7544895e82c1

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nrishel, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 11

[Nick Rishel [:nrishel]]

Comment on attachment 9324068 [details]
Bug 1822842 - Trim down notification server event viewer logging unless alerts.useSystemBackend.windows.notificationserver.verbose=true. r=nalexander

Beta/Release Uplift Approval Request

• User impact if declined: Noisy false positive errors visible to users in Windows Event Logs.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Follows existing patterns in code (adding and parsing an argument to flip a a switch), trivial to audit.
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9324068 [details]
Bug 1822842 - Trim down notification server event viewer logging unless alerts.useSystemBackend.windows.notificationserver.verbose=true. r=nalexander

Approved for 112.0b8

Comment 13

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e4a02a77ee81