1822931 - Bad signature for a Maybe method

Status: RESOLVED FIXED

(Socorro :: Signature, task)

Description

[Andrew McCreight [:mccr8]]

The top frame of this crash is mozilla::Maybe<unsigned long>::value() const& but somehow that got turned into just [@ const], which is not very helpful.

Comment 1

[Gabriele Svelto [:gsvelto]]

It seems like the actual symbol for this function is mozilla::Maybe<unsigned long>::value() const & (note the space after the const keyword) and this is tripping Socorro's signature generator which expects it to be const& instead of const &. I'll double-check if this is an issue with dump_syms, if it's not then we'll just have to tweak Socorro.

Comment 2

[Gabriele Svelto [:gsvelto]]

dump_syms is processing the symbol correctly, all the demanglers I tried spit out mozilla::Maybe<unsigned long>::value() const & so we'll have to tweak Socorro. Patch incoming.

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: pr 6374: Bug 1822931 - Fix constant reference qualifiers in signatures

Comment 4

[Jens Stutte [:jstutte]]

(In reply to Andrew McCreight [:mccr8] from comment #0)

The top frame of this crash is mozilla::Maybe<unsigned long>::value() const& but somehow that got turned into just [@ const], which is not very helpful.

It seems to me that this crash used to be bug 1592404 but that its signature has been changed by bug 1791758. So once this patch is through we might need to update also the signature prefix will hopefully see them arrive again there.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6374: "Bug 1822931 - Fix constant reference qualifiers in signatures" in 9cf0805.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this out just now in bug #1824987. Marking as FIXED.