1822975 - Stop setting javascript.options.asyncstack_capture_debuggee_only manually from devtools mochitests

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

In Bug 1822618, javascript.options.asyncstack_capture_debuggee_only is now set to false by default for mochitests.

This means we could cleanup a bit the devtools test codebase, which was manually setting this preference to false from shared-head.js as well as in some other tests:

https://searchfox.org/mozilla-central/search?q=javascript.options.asyncstack_capture_debuggee_only&path=devtools&case=false&regexp=false

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1822975 - clean up places that manually enable broader async stacks which is now the default in tests, r?#devtools-reviewers!,#firefox-desktop-core-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94a2d660b4c5
clean up places that manually enable broader async stacks which is now the default in tests, r=devtools-reviewers,firefox-desktop-core-reviewers ,geckoview-reviewers,mconley,ohall

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing browser_net_accessibility related devtools failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_accessibility-01.js | The selected item in the requests menu was incorrect. - Got 2, expected 1

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:Gijs, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[:Gijs (he/him)]

Yes, I'm just busy...

Comment 6

[:Gijs (he/him)]

https://treeherder.mozilla.org/jobs?repo=try&revision=d4785112bbf60976ed9185ff1336844468d912b3

Comment 7

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #6)

https://treeherder.mozilla.org/jobs?repo=try&revision=d4785112bbf60976ed9185ff1336844468d912b3

lol, this is just a rebase but it's green?

So I guess I'll just reland...

Comment 8

[Julian Descottes [:jdescottes]]

I tried to investigate a bit, but could not really identify why this works now.

The initial failure was due to the fact that initNetMonitor was a bit faster with your patch (because it removed an await to set the preference), and sometimes the netmonitor would unexpectedly pickup a failed (?) request from the page. With this additional request in the requests list, the asserts would randomly fail (more or less depending on where the additional request ended up in the list).

With more recent builds this no longer happens, the document request no longer shows up during the test. I suspected a few changes we did around network events for devtools but they seem unrelated. Anyway, the initial backout was only a side effect from your patch which only exposed the fragility of one of our netmonitor tests, so hopefully it sticks now.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/524a3ca70321
clean up places that manually enable broader async stacks which is now the default in tests, r=devtools-reviewers,firefox-desktop-core-reviewers ,geckoview-reviewers,mconley,ohall

Comment 10

[Julian Descottes [:jdescottes]]

I think I identified the culprit: the failed request was showing up because of Bug 1903292. Since this was fixed we no longer have the problem

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/524a3ca70321

Comment 12

[James Teh [:Jamie] (away returning 28 Jan)]

I came here worried that this might not be working for a11y tests for some reason because we had to explicitly set it in bug 1822225. It turns out that I landed the patch in bug 1822225 two days before the patch in bug 1822618! That is, the latter patch invalidated the need for the former, but only two days after the former landed. What a bizarre coincidence.