1823214 - Refactor mul_by function for calc nodes into more generic map function

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Tiaan Louw [:tlouw]]

The mul_by function for calc nodes does a multiplication on each leaf node in a calc tree. We need to do more operations on each leaf node, e.g. abs, signum, divide, etc.

Change the mul_by fn to a map fn and then we can use that to do mul_by and all the other operations.

Comment 1

[Tiaan Louw [:tlouw]]

Attachment: Bug 1823214 - Refactor mul_by fn into map fn. r=emilio,#layout-reviewers

Refactor the mul_by function into a more generic map function that can
be used for more operations like abs, signum and mul.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1823214 - Minor clean ups on top of the previous patch. r=tlouw

Remove now dead Mul implementations. Use Self rather than the whole type
to shrink a bit the code.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e159a61ff71
Refactor mul_by fn into map fn. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92224387c48d
Minor clean ups on top of the previous patch. r=tlouw

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/7e159a61ff71
https://hg.mozilla.org/mozilla-central/rev/92224387c48d