1823215 - Use ElementOrArray to manage the glyph run(s) in gfxTextRun

Status: RESOLVED FIXED

(Core :: Graphics: Text, task)

Description

[Jonathan Kew [:jfkthame]]

Bug 1822184 introduced the ElementOrArray<T> class, which serves a bit like an AutoTArray<T, 1>, but is memmovable, and more compact because it doesn't store both an array header and an inline buffer.

This provides similar functionality to how gfxTextRun manages its GlyphRun records.

So having created the ElementOrArray<T> template, we can switch gfxTextRun to use this and simplify its management of the runs.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1823215 - Extract ElementOrArray<T> from CanvasRenderingContext2D into gfxUtils.h so it can also be used elsewhere in gfx/thebes. r=#gfx-reviewers

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1823215 - Add API to ElementOrArray to support use in gfxTextRun to store the glyph run(s). r=#gfx-reviewers

Depends on D172938

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1823215 - Use ElementOrArray<T> to simplify the management of glyphrun(s) in gfxTextRun. r=#gfx-reviewers

Depends on D172939

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c15d9a19b49
Extract ElementOrArray<T> from CanvasRenderingContext2D into gfxUtils.h so it can also be used elsewhere in gfx/thebes. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/8bb283e5ea91
Add API to ElementOrArray to support use in gfxTextRun to store the glyph run(s). r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/654284175f6e
Use ElementOrArray<T> to simplify the management of glyphrun(s) in gfxTextRun. r=gfx-reviewers,lsalzman

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7c15d9a19b49
https://hg.mozilla.org/mozilla-central/rev/8bb283e5ea91
https://hg.mozilla.org/mozilla-central/rev/654284175f6e