[wdspec] Add more tests that check the "value" wrapped response
Categories
(Remote Protocol :: Marionette, enhancement, P2)
Tracking
(firefox-esr102 unaffected, firefox111 unaffected, firefox112 affected, firefox113 affected)
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox111 | --- | unaffected |
| firefox112 | --- | affected |
| firefox113 | --- | affected |
People
(Reporter: whimboo, Unassigned)
References
()
Details
(Whiteboard: [webdriver:backlog])
As reported on the GitHub issue there is a change in behavior for Firefox in the upcoming Firefox 112 release. Specifically for Get Element Property the response payload has been changed when requesing the value of the element's classList property:
Firefox 111:
1679303918219 Marionette DEBUG 3 -> [0,4,"WebDriver:GetElementProperty",{"id":"bd3bf998-3f03-4b52-a255-21e8f2175ea6","name":"classList"}]
1679303918219 Marionette DEBUG 3 <- [1,4,null,{"item":{},"contains":{},"add":{},"remove":{},"replace":{},"toggle":{},"supports":{},"keys":{}," ...
Firefox 112:
1679303891740 Marionette DEBUG 3 -> [0,4,"WebDriver:GetElementProperty",{"id":"e25ad7a6-987a-4add-8c8e-a6dc1b7f22bc","name":"classList"}]
1679303891743 Marionette DEBUG 3 <- [1,4,null,{"value":{"item":{},"contains":{},"add":{},"remove":{},"replace":{},"toggle":{},"supports":{},"keys":{}," ...
Note that this happens only for certain returned types like an array, and this has been caused by my changes on bug 1819029. But this is not a regression but a fix to no longer accidentally return non-value wrapped responses for some types only. Means we are more robust now.
As such we should extend the wdspec tests and enhance the response checks to include various different data types - at least for those commands that would allow that.
I think that we should do that sooner than later to know which exact commands are affected and might show a different behavior compared to version 111.
|
Reporter | |
Updated•1 year ago
|
Description
•