1823520 - The categories on about:preferences overlap the links below, when zooming in the page

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Itiel]

Attachment: Screenshot

STR:

1. Open about:preferences
2. Zoom the page, see the categories on the left

Comment 1

[Alice0775 White]

Or
Reduce the browser height.
Screenshot: https://youtu.be/_-3Jfl3j9Tw

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1822131

:emilio, since you are the author of the regressor, bug 1822131, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1823520 - Fix category list styling on small windows. r=mconley,Gijs

Usually richlistboxes like this are scrollable and can shrink, but in
this particular case we want to avoid the scrolling and prevent it from
shrinking vertically.

My patch to allow XUL to shrink made it go from an effective
flex-shrink: 0 to 1, which combined with its min-height: 0 from the UA
stylesheet allows it to shrink when it previously didn't.

We could use flex-shrink: 0 for our purposes as well and it'd achieve
the same behavior, but min-height: auto works in grid as well, so is a
tad nicer IMO. Either way tho.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70a7f90e6ec6
Fix category list styling on small windows. r=Gijs,settings-reviewers

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/70a7f90e6ec6

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-03-20 Nightly build on macOS 12.
Verified as fixed on Firefox 113.0b7(build ID: 20230423180101) and Nightly 114.0a1(build ID: 20230424095046) on macOS 12, Windows 10, Ubuntu 22.