Closed Bug 1823557 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39097 - [Topics] add Topics header for iframe navigation request

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39097 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39097
Details from upstream follow.

Yao Xiao <yaoxia@chromium.org> wrote:

[Topics] add Topics header for iframe navigation request

Implement topics navigation header:

  • Before a request or redirect is handled (i.e. NavigationRequest's
    constructor, and OnRedirectChecksComplete()), calculate and append
    the header.
  • After the corresponding response is received (i.e.
    OnRedirectChecksComplete() and CommitNavigation()), check and handle
    the topics response header.

Also, fixed the checks in HTMLIFrameElement::ParseAttribute() and
HTMLIFrameElement::DidChangeAttributes(): currently, the RuntimeFeature
and SecureContext are not properly checked when the iframe attribute is
set via setAttribute. The annotation in the IDL wasn't sufficient.

Bug: 1352345
Change-Id: Ia84c67e8f9858a98d7161668bc82fa688c563497
Reviewed-on: https://chromium-review.googlesource.com/4356935
WPT-Export-Revision: a9f4254f34bc13b61c244f2d42a3c1e6e552fdae

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 2 subtests

Status Summary

Firefox

OK : 2
PASS : 10
FAIL : 11
TIMEOUT: 9

Chrome

OK : 1
PASS : 8
CRASH : 1
FAIL : 11
TIMEOUT: 9

Safari

OK : 2
PASS : 10
FAIL : 11
TIMEOUT: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /browsing-topics/browsing-topics-permissions-policy-default.tentative.https.sub.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • Default permissions policy allows document.browsingTopics() in the current page.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Default permissions policy allows document.browsingTopics() in same-origin iframes.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • Default permissions policy allows document.browsingTopics() in cross-origin iframes.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • Default permissions policyallows the 'Sec-Browsing-Topics' header to be sent for the same-origin topics fetch request.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Default permissions policyallows the 'Sec-Browsing-Topics' header to be sent for the cross-origin topics fetch request.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Default permissions policy allows the 'Sec-Browsing-Topics' header to be sent for the same-origin iframe navigation request.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Default permissions policy allows the 'Sec-Browsing-Topics' header to be sent for the cross-origin iframe navigation request.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /browsing-topics/browsing-topics-permissions-policy-none.tentative.https.sub.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • permissions policy header browsing-topics=() disallows document.browsingTopics() in the current page.: FAIL (Chrome: FAIL, Safari: FAIL)
    • permissions policy header browsing-topics=() disallows document.browsingTopics() in same-origin iframes.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • permissions policy header browsing-topics=() disallows document.browsingTopics() in cross-origin iframes.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • /browsing-topics/browsing-topics-permissions-policy-self.tentative.https.sub.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • permissions policy header browsing-topics=(self) allows document.browsingTopics() in the current page.: FAIL (Chrome: FAIL, Safari: FAIL)
    • permissions policy header browsing-topics=(self) allows document.browsingTopics() in same-origin iframes.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • permissions policy header browsing-topics=(self) disallows document.browsingTopics() in cross-origin iframes.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
    • permissions policy header browsing-topics=(self)allows the 'Sec-Browsing-Topics' header to be sent for the same-origin topics fetch request.: FAIL (Chrome: FAIL, Safari: FAIL)
    • permissions policy header browsing-topics=(self)allows the 'Sec-Browsing-Topics' header to be sent for the redirect of a topics fetch request, where the redirect has a same-origin URL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • permissions policy header browsing-topics=(self) allows the 'Sec-Browsing-Topics' header to be sent for the same-origin iframe navigation request.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /browsing-topics/iframe-topics-attribute.tentative.https.html [wpt.fyi]
    • test <iframe browsingtopics src=[url]></iframe>: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c62f3d9ea84 [wpt PR 39097] - [Topics] add Topics header for iframe navigation request, a=testonly https://hg.mozilla.org/integration/autoland/rev/e8b947fb7540 [wpt PR 39097] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2c62f3d9ea84
https://hg.mozilla.org/mozilla-central/rev/e8b947fb7540

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.