1823610 - Console messages timestamps are not printed in saved file

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Anmol]

Attachment: Firefox.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36

Steps to reproduce:

• Enable Timestamps and Log Persistence on the console window
• Save the file as .txt

Actual results:

The timestamps do not show up

Expected results:

The file should show timestamps present as it was enabled

Comment 1

[nicoleta.sibisan]

Hello,
Thank you for reporting this.

I reproduced de issue on MacOS12, Win 11 and Ubuntu 22 and with Fx versions: 111.0.1 (64-bit), 112.0b6 (64-bit) and Nightly 113.0a1 (2023-03-23)
with the following steps:

1. Launch Firefox
2. R-click on the page and select Inspect.
3. Go to the Console tab
4. Click on the Console Settings button and make sure “Show Timestamps” and “Persist Logs” options are checked.
5. In the same Fx tab, in the address bar, go to https://utest.com/
6. In the Console tab, R-click anywhere on the displayed messages and select “Save all Messages to file”
7. Save the file.
8. Open the file and observ its content.

It does not reproduce in Fx versions: 102.9.0esr, 110.0a1 (2022-12-12).

Regression range
Last known good: 111.0a1 (2023-02-05)
First known bad: 111.0a1 (2023-02-06)
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d8601249f1eb8c52c742b0c19c9ca0fa8f2e31fe&tochange=b06e825a4d8137434a1524b1ef7049f85cdc60d1

Additional notes
On the message:
R-click ->Copy Message -> both the message and the timestamp are copied
R-click ->Copy all Messages ->only the messages is copied

Comment 2

[Donal Meehan [:dmeehan]]

:nchevobbe looks like this was regressed by Bug 1814855?
Could you take a look?
It's too late for 111, but if there's anything we can do for 112?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Sure, looks like the container query added in Bug 1814855 is causing this

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1823610 - [devtools] Don't hide timestamp when exporting console messages. r=#devtools-reviewers.

The media query we introduced not long ago to hide
timestamp on narrow output was also effective for
the element we use for the export (as it has a width
of 0), which means timestamp wouldn't be included
in the export.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d7d50176a3b
[devtools] Don't hide timestamp when exporting console messages. r=devtools-reviewers,jdescottes.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3d7d50176a3b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9325502 [details]
Bug 1823610 - [devtools] Don't hide timestamp when exporting console messages. r=#devtools-reviewers.

Beta/Release Uplift Approval Request

• User impact if declined: timestamps missing from webconsole exported message
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): devtools only, one-liner CSS change covered by mochitest
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9325502 [details]
Bug 1823610 - [devtools] Don't hide timestamp when exporting console messages. r=#devtools-reviewers.

Approved for 112.0b9

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cfae6a8ffe95

Comment 11

[nicoleta.sibisan]

Verified - fixed on MacOS 12, Win 11 and Ubuntu 18 in Fx versions 112.0b9 and latest Nightly 113.0a1 (2023-03-30).