1823644 - Optimize textrun initialization by merging SanitizeGlyphRuns and SortGlyphRuns

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement)

Description

[Jonathan Kew [:jfkthame]]

After the initial creation of glyph runs in a gfxTextRun instance, we make two "cleanup" passes over the array of runs: first, SanitizeGlyphRuns adjusts for ligature boundaries if necessary, and eliminates any runs that end up empty as a result; and then SortGlyphRuns ensures they are ordered by character offset, and merges any adjacent runs with identical properties.

With a bit of care, I think we can merge these and do the cleanup in a single pass.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1823644 - Optimize textrun initialization by merging SanitizeGlyphRuns and SortGlyphRuns. r=#gfx-reviewers

No change in behavior, just a marginal optimization when creating large/complex textruns.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e77d576d2a1b
Optimize textrun initialization by merging SanitizeGlyphRuns and SortGlyphRuns. r=gfx-reviewers,lsalzman

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e77d576d2a1b