1823648 - 9.07 - 6.84% instagram PerceptualSpeedIndex / instagram PerceptualSpeedIndex + 1 more (Windows) regression on Wed March 15 2023

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Andra Esanu (needinfo me)]

Perfherder has detected a browsertime performance regression from push b5cc339840e61286a844589787c997c9fd5583a4. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
9%	instagram PerceptualSpeedIndex	windows10-64-shippable-qr	cold fission webrender	638.79 -> 696.75	Before/After
7%	instagram PerceptualSpeedIndex	windows10-64-shippable-qr	cold fission webrender	637.92 -> 682.17	Before/After
7%	instagram PerceptualSpeedIndex	windows10-64-shippable-qr	fission warm webrender	327.67 -> 350.08	Before/After

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
4%	instagram LastVisualChange	windows10-64-shippable-qr	fission warm webrender	632.21 -> 605.58	Before/After
3%	instagram ContentfulSpeedIndex	windows10-64-shippable-qr	fission warm webrender	449.79 -> 435.83	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Andra Esanu (needinfo me)]

This was backed out by https://bugzilla.mozilla.org/show_bug.cgi?id=1821233#c4

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1821233

Comment 3

[Glenn Watson [:gw]]

The screenshots in the before / after profiles are different. Is this actually relevant still, given that the patch was backed out and re-landed with a fix (which probably caused those screenshot differences).

Comment 4

[Andra Esanu (needinfo me)]

(In reply to Glenn Watson [:gw] from comment #3)

The screenshots in the before / after profiles are different. Is this actually relevant still, given that the patch was backed out and re-landed with a fix (which probably caused those screenshot differences).

No, it's not relevant anymore.