Closed Bug 1823706 Opened 2 years ago Closed 2 years ago

Rename tabbrowser's addMultipleTabs and batchInsertingTabs to make it clear session restore is the only consumer

Categories

(Firefox :: Tabbed Browser, defect)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

batchInsertingTabs means we end up not inserting tabs into the DOM immediately, which means during addTab the tab may not have a _tPos, which can break consumers' expectations. Right now session restore is the only consumer so we'd be better off making some of the expectations around this clearer.

This is being split out from bug 1822854 to allow uplifting the fix in that bug to beta.

Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bfd15c181efe rename addMultipleTabs and batchInsertingTabs parameter for clarity, r=dao
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: