1823776 - Handle Show Migration Wizard special action when its two level deep inside MULTI_ACTION

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Fix of bug https://phabricator.services.mozilla.com/D172593 embeds SHOW_MIGRATION_WIZARD inside MULTI_ACTION of MULTI_ACTION which is not handled explicitly inside handleAction method of MultiStageAboutWelcome.jsx and results in not waiting migration wizrad to close before moving to next screen.

Eventually with import wizard 2.0 we should be able to remove this code and not need to explicit check for migration wizard to close

Scope of this bug is to update below check to look for "SHOW_MIGRATION_WIZARD" inside MULTI_ACTION of MULTI_ACTION .

https://searchfox.org/mozilla-central/rev/137075514eddc08c68ff652e9899da82e8043574/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#332

Comment 1

[Shane Hughes [:aminomancer]]

Maybe this would be a good opportunity to revisit refactoring MULTI_ACTION into a promise? Then we could even handle SHOW_MIGRATION_WIZARD in MULTI_ACTION^3 😂

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1823776 - Handle SHOW_MIGRATION_WIZARD inside nested MULTI_ACTION

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7499fec26e52
Handle SHOW_MIGRATION_WIZARD inside nested MULTI_ACTION r=pdahiya,omc-reviewers,aminomancer

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7499fec26e52

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 113.0a1 (Build ID: 20230404134922) on macOS 11.7.1.

• After following the testing steps from this Test Plan, I confirm the following:
  • The “Import Wizard” is opened on the same screen after clicking the primary button of the “Easy Setup” screen.
  • The ”messaging-system-action.easyImport” pref is set to true.
  • After completing the Import flow, the New Tab page shows.