1823797 - Convert browser_JsonSchemaValidator.js and browser_ClientEnvironment.js to xpcshell tests

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

browser_JsonSchemaValidator.js currently runs as a mochitest, but it is only testing the JsonSchemaValidator module and that isn't doing anything above what xpcshell is capable of.

We should move it across to an xpcshell-test to make it simpler to run/develop.

Comment 1

[Mark Banner (:standard8)]

I just noticed that we can do the same with browser_ClientEnvironment.js - it says it relies on XULAppInfo, but we can make that available in an xpcshell-test.

Hence we can remove both mochitests in toolkit/components/utils/.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1823797 - Convert browser_JsonSchemaValidator.js to a xpcshell-test. r?Mossop!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1823797 - Remove browser_ClientEnvironment.js; merge its content into the xpcshell-test. r?Mossop!

Depends on D173365

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f449a95cc7b
Convert browser_JsonSchemaValidator.js to a xpcshell-test. r=mossop
https://hg.mozilla.org/integration/autoland/rev/64604190f082
Remove browser_ClientEnvironment.js; merge its content into the xpcshell-test. r=mossop

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0f449a95cc7b
https://hg.mozilla.org/mozilla-central/rev/64604190f082