1823871 - [wpt-sync] Sync PR 39136 - WebRTC WPT: improve header extension control tests

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39136 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39136
Details from upstream follow.

Philipp Hancke <[e-mail]> wrote:

WebRTC WPT: improve header extension control tests

as well as the JS style.

BUG=chromium:1051821

Change-Id: Ie70c50cc239d7a7567f76c04878a502123e1fa9e
Reviewed-on: https://chromium-review.googlesource.com/4355141
WPT-Export-Revision: 302c05a9c3c2367e90a172c18b2317970e42b177

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 39136 applied with additional changes from upstream: 35ae832f96760b175947c3cf556c60172029fd56

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c87d8a79767385caca7ca42c460bb785e8c02b91

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 16 subtests

Status Summary

Firefox

OK : 1
FAIL: 16

Chrome

OK : 1
PASS: 16

Safari

OK : 1
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • the audio transceiver.getHeaderExtensionsToNegotiate() includes mandatory extensions: FAIL (Chrome: PASS, Safari: FAIL)
  • the video transceiver.getHeaderExtensionsToNegotiate() includes mandatory extensions: FAIL (Chrome: PASS, Safari: FAIL)
  • setHeaderExtensionsToNegotiate throws TypeError on encountering missing URI: FAIL (Chrome: PASS, Safari: FAIL)
  • setHeaderExtensionsToNegotiate throws TypeError on encountering missing direction: FAIL (Chrome: PASS, Safari: FAIL)
  • setHeaderExtensionsToNegotiate throws InvalidModificationError on encountering unknown URI: FAIL (Chrome: PASS, Safari: FAIL)
  • setHeaderExtensionsToNegotiate throws InvalidModificationError when removing elements from the list: FAIL (Chrome: PASS, Safari: FAIL)
  • setHeaderExtensionsToNegotiate throws InvalidModificationError when adding elements to the list: FAIL (Chrome: PASS, Safari: FAIL)
  • setHeaderExtensionsToNegotiate throws InvalidModificationError when setting a mandatory header extension's direction to something else than "sendrecv": FAIL (Chrome: PASS, Safari: FAIL)
  • modified direction set by setHeaderExtensionsToNegotiate is visible in subsequent getHeaderExtensionsToNegotiate: FAIL (Chrome: PASS, Safari: FAIL)
  • Unstopped extensions turn up in offer: FAIL (Chrome: PASS, Safari: FAIL)
  • Stopped extensions do not turn up in offers: FAIL (Chrome: PASS, Safari: FAIL)
  • The set of negotiated extensions has the same size as the set of extensions to negotiate: FAIL (Chrome: PASS, Safari: FAIL)
  • Header extensions can be reactivated in subsequent offers: FAIL (Chrome: PASS, Safari: FAIL)
  • Header extensions can be deactivated on a per-mline basis: FAIL (Chrome: PASS, Safari: FAIL)
  • Extensions not negotiated by the peer are stopped in getNegotiatedHeaderExtensions: FAIL (Chrome: PASS, Safari: FAIL)
  • Prior to negotiation, getNegotiatedHeaderExtensions() returns stopped for all extensions.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb24ba774f82
[wpt PR 39136] - Make RTP header extension capability direction and uri attributes required, a=testonly

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/eb24ba774f82