1823960 - (SQLite3.41.2) Upgrade to SQLite 3.41.2

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, task)

Description

[Ryan VanderMeulen [:RyanVM]]

Additional changes in version 3.41.2 (2023-03-22):

• Multiple fixes for reads past the end of memory buffers (NB: reads not writes) in the following circumstances:
  • When processing a corrupt database file using the non-standard SQLITE_ENABLE_STAT4 compile-time option.
  • In the CLI when the sqlite3_error_offset() routine returns an out-of-range value (see change item 21 below).
  • In the recovery extension.
  • In FTS3 when processing a corrupt database file.
• Fix the sqlite3_error_offset() so that it does not return out-of-range values when reporting errors associated with generated columns.
• Multiple fixes in the query query optimizer for problems that cause incorrect results for bizarre, fuzzer-generated queries.
• Increase the size of the reference counter in the page cache object to 64 bits to ensure that the counter never overflows.
• Fix a performance regression caused by a bug fix in patch release 3.41.1.
• Fix a few incorrect assert() statements.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1823960 - Upgrade to SQLite 3.41.2. r=mak

Comment 2

[Marco Bonardo [:mak]]

Not super critical, the only things that may affect us are:

• In FTS3 when processing a corrupt database file.

May affect Thunderbird.

• Fix a performance regression caused by a bug fix in patch release 3.41.1.

Unclear how extensive this regression is. Unless we learn more about it, may not be worth uplifting.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9145ee5b81a1
Upgrade to SQLite 3.41.2. r=mak

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9145ee5b81a1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9324491 [details]
Bug 1823960 - Upgrade to SQLite 3.41.2. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: Possible performance and stability issues. Honestly, it's probably not super important to backport this per Mak's comment, but the 3.41 release shipping in 112 was the first update we took to SQLite in awhile and it seems like a decent idea to ship with the latest-available patch release when 112 goes out the door.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): SQLite is extremely well-tested and this is a minor bugfix release to what we already have in-tree for 112.
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9324491 [details]
Bug 1823960 - Upgrade to SQLite 3.41.2. r=mak

Approved for 112.0b6

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bddf5efd5d4c