Closed Bug 1823999 Opened 3 years ago Closed 2 years ago

[Tabs tray to Compose] Refactor `TabsTrayFragment.showUndoSnackbarForTab` to support Compose implementation

Categories

(Firefox for Android :: Tabs, task, P3)

All
Android
task

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: 007, Assigned: 007)

References

Details

(Whiteboard: [fxdroid])

Attachments

(1 file)

Currently, showUndoSnackbarForTab depends on the XML FAB + an XML tab layout mediator. This function should be refactored to simply update TabsTrayState (if tabsUseCases.undo doesn't already do this) and allow the Compose UI to react to the state changes.

Whiteboard: [fxdroid]
Assignee: nobody → nbond
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

Hello Noah Bond,

We have verified that the 'UNDO' Snackbar behaves correctly for this issue on Motorola Moto G9 plus (Android 11) using the latest Nightly 114.0a1 - 3rd of May. Is there anything else that we should verify regarding this issue?

Thank you!

Flags: needinfo?(nbond)

This ticket actually didn't need validation yet (it landed overnight for me, so before I could remove the flag, sorry about that), but thanks for doing some validation! This ticket is all set for now.

Flags: needinfo?(nbond)
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: