[Tabs tray to Compose] Refactor `TabsTrayFragment.showUndoSnackbarForTab` to support Compose implementation
Categories
(Firefox for Android :: Tabs, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: 007, Assigned: 007)
References
Details
(Whiteboard: [fxdroid])
Attachments
(1 file)
Currently, showUndoSnackbarForTab depends on the XML FAB + an XML tab layout mediator. This function should be refactored to simply update TabsTrayState (if tabsUseCases.undo doesn't already do this) and allow the Compose UI to react to the state changes.
| Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
| Assignee | ||
Updated•3 years ago
|
| Assignee | ||
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/3807653ff510f565a7a80cf5e8569357fdab8c00
[main] Bug 1823999 - Fix UNDO Snackbar for composified Tabs Tray
Comment 3•2 years ago
•
|
||
Hello Noah Bond,
We have verified that the 'UNDO' Snackbar behaves correctly for this issue on Motorola Moto G9 plus (Android 11) using the latest Nightly 114.0a1 - 3rd of May. Is there anything else that we should verify regarding this issue?
Thank you!
| Assignee | ||
Comment 4•2 years ago
|
||
This ticket actually didn't need validation yet (it landed overnight for me, so before I could remove the flag, sorry about that), but thanks for doing some validation! This ticket is all set for now.
Updated•2 years ago
|
Description
•