1824016 - Feature Callout in PDF viewer does not point to the correct elements in full screen mode

Status: RESOLVED INCOMPLETE

(Firefox :: Messaging System, defect, P2)

Description

[Meg Viar [:mviar]]

Attachment: Example

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

Change the "browser.pdfjs.feature-tour" pref to '{"screen":"FEATURE_CALLOUT_1_A","complete":false}', opened a PDF in Firefox 111, went to full screen mode (this also occurs if you start in full screen mode)

Actual results:

The feature callout does point to the correct icons in the PDF viewer

Expected results:

It should point to the correct icons in the PDF viewer toolbar in full screen mode.

Comment 1

[Shane Hughes [:aminomancer]]

The callout is anchored to the window rather than the browser, so this seems like a difficult problem to solve. I wonder if finding a way to put the pdfjs callout into the content would be a better investment, since it's more generalizable to other use cases, and could also solve the issue of some of our special message actions not working for feature callouts because they pass the doc instead of the browser. That's a complicated refactor but it should basically us up to display callouts in any content window as well as in the chrome (for parent elements that actually exist in the chrome).

Comment 2

[Ciprian Georgiu, Desktop QA]

I cannot reproduce this problem with latest Nightly 118.0a1 or with Firefox 111, using macOS 11 and macOS 10.15. The Feature Callout in PDF viewer is pointing the correct icon while being in fullscreen.

Hi, Meg Viar! Are you still seeing this issue with latest Nightly, can you please check again?

Comment 3

[Shane Hughes [:aminomancer]]

Attachment: screenshot

I can reproduce it on m-c. The window needs to be in fullscreen mode (not DOM fullscreen, i.e. the fullscreen triggered by clicking the fullscreen button on a video, but the one triggered by F11) with a non-native toolbar. Maybe on macOS it requires browser.tabs.inTitlebar to be set to 1 or something. Anyway, in fullscreen mode the toolbar disappears when not hovering or focusing it. But in the process of opening a PDF you might be hovering the toolbar, e.g. drag and dropping a PDF file into the tab strip. And then a PDF tab opens while the toolbar is visible, causing a callout to be positioned under the toolbar. But when you move your mouse out of the toolbar, the toolbar disappears again, leaving a bunch of space above the callout, and the callout does not reposition. Because there's no logic for making it reposition when the coordinates of the anchor element change.

This can technically be fixed by bug 1842366. Loading callouts as panels allows them to 'passively' follow the anchor around the screen. We didn't have express plans to change the existing PDF.js messages, since they aren't shown to any audience now, but when we do the next PDF.js experiment we'll probably implement it that way.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

A needinfo is requested from the reporter, however, the reporter is inactive on Bugzilla. Closing the bug as incomplete.

For more information, please visit BugBot documentation.