Closed Bug 1824039 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39152 - NavigationAPI: navigateEvent.commit() and { commit: 'manual' }

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39152 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39152
Details from upstream follow.

Nate Chapin <japhet@chromium.org> wrote:

NavigationAPI: navigateEvent.commit() and { commit: 'manual' }

Explainer: https://github.com/WICG/navigation-api#manual-commit
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/Aef4fm1Wn18

This introduces a new commit option on navigateEvent.intercept().
When commit is set to 'manual', instead of immediately committing
the navigation when the NavigateEvent finishes dispatch, we defer the
commit until navigateEvent.commit() is called or just before
navigatesuccess fires (whichever comes first).

Change-Id: Ife63c552dc89923b5e205cd6cad210dad7d222fd

Reviewed-on: https://chromium-review.googlesource.com/3794770
WPT-Export-Revision: 0f13da0ac7c38d80103d0a98a56e7327ea997c16

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 91 tests and 1 subtests

Status Summary

Firefox

OK : 89[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 90[GitHub]
FAIL : 121[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 122[GitHub]
TIMEOUT: 2

Chrome

OK : 87
PASS : 73
FAIL : 44
TIMEOUT: 5
ERROR : 1

Safari

OK : 88
FAIL : 120
TIMEOUT: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7d3a7db9757 [wpt PR 39152] - NavigationAPI: navigateEvent.commit() and { commit: 'after-transition' }, a=testonly https://hg.mozilla.org/integration/autoland/rev/63fbdd6da3b6 [wpt PR 39152] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.