1824121 - Implement the <search> element

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Simon Pieters [:zcorpan]]

See https://github.com/whatwg/html/pull/7320

• changes to the HTML parser
• changes to the UA stylesheet
• changes to a11y mapping (https://github.com/w3c/html-aam/pull/355)

Comment 1

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1824121 - Implement the <search> element

Implemented the new <search> HTML element.
All WPT tests except one for iso-8859-8 now pass.

Generation/automatic version is currently broken (file bug?), so done manually
but should be fine as WPT tests pass well.

WIP. TODO:

• Ensure changes fit and see who can review?
• Investigate remaining single failing WPT subtest with iso-8859-8
• a11y mapping

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D176967	Bug 1824121 - Implement the <search> element	canadahonk	hsivonen: Back Jun 13, 2023

:canadahonk, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 3

[Oliver Medhurst [:canadahonk]]

There is no other reviewer for this (HTML parser) afaik, and the wait should be fine (also seemingly still being a bit jank?). Open to someone else reviewing instead if they think they can though.

Comment 4

[Oliver Medhurst [:canadahonk]]

This was just implemented in Safari TP 171: https://webkit.org/blog/14200/release-notes-for-safari-technology-preview-171/

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Parser patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c309e9b48aec
Implement the <search> element r=hsivonen,Jamie,emilio

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing several element related mochitest failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=c309e9b48aec470f46357d029dc89a042e91c197&selectedTaskRun=BtLdtEFwTF6v65FJ5uxiFA.0

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=425158398&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=425158448&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=425158507&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc21f77497eba1c81f1e7c2067fa6e49c3387876

Comment 8

[Oliver Medhurst [:canadahonk]]

Bug in HTML parser changes, should be fixed in latest diff.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ff5c272ab8e
Implement the <search> element r=hsivonen,Jamie,emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3a3324b1732
Fix assertion on HTMLEditUtils.cpp. a=test-fix CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3aec91d79e4
Include nsHtml5HtmlAttributes.h to fix Bp-nu build bustages. a=bustage-fix CLOSED TREE

Comment 12

[Serban Stanca [:SerbanS]]

Backed out for causing wpt failures in html5lib_search-element.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /html/syntax/parsing/html5lib_search-element.html?run_type=uri | html5lib_search-element.html 114b9f3c8147c0ed8ef3ed1811a9da3f10d74402 - expected FAIL

Comment 13

[Oliver Medhurst [:canadahonk]]

Fixed WPT expectations (tests were added after patch was created).

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b41411bad0dc
Implement the <search> element r=hsivonen,Jamie,emilio

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b41411bad0dc

Comment 16

[Dave Letorey]

Content PR

Comment 17

[Oliver Medhurst [:canadahonk]]

Just noticed this wasn't in the 118 beta release notes (but in the developer notes). I think this probably should be in the final notes? Apologies.

Release Note Request (optional, but appreciated)
[Why is this notable]: New (minor/a11y) HTML element supported
[Affects Firefox for Android]: Yes
[Suggested wording]: The <search> element is now supported.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/search

Comment 18

[Dianna Smith [:diannaS]]

Added to 118 beta and release notes https://www.mozilla.org/en-US/firefox/118.0/releasenotes/

Comment 19

[Henri Sivonen (:hsivonen)]

https://github.com/validator/htmlparser/commit/76ad039dbed9d07d2ff3d6dea843fbd6b6732072