Closed Bug 1824121 Opened 8 months ago Closed 4 months ago

Implement the <search> element


(Core :: DOM: HTML Parser, enhancement)




118 Branch
Tracking Status
relnote-firefox --- 118+
firefox113 --- wontfix
firefox118 --- fixed


(Reporter: zcorpan, Assigned: canadahonk)


(Blocks 1 open bug, )


(Keywords: dev-doc-complete, parity-safari)


(2 files)


Depends on: 1824176
Type: defect → enhancement

Implemented the new <search> HTML element.
All WPT tests except one for iso-8859-8 now pass.

Generation/automatic version is currently broken (file bug?), so done manually
but should be fine as WPT tests pass well.


  • Ensure changes fit and see who can review?
  • Investigate remaining single failing WPT subtest with iso-8859-8
  • a11y mapping
Attachment #9331263 - Attachment description: WIP: Bug 1824121 - Implement the <search> element → Bug 1824121 - Implement the <search> element
Assignee: nobody → oj

The following patch is waiting for review from an inactive reviewer:

ID Title Author Reviewer Status
D176967 Bug 1824121 - Implement the <search> element canadahonk hsivonen: Back Jun 13, 2023

:canadahonk, could you please find another reviewer?

For more information, please visit BugBot documentation.

Flags: needinfo?(oj)

There is no other reviewer for this (HTML parser) afaik, and the wait should be fine (also seemingly still being a bit jank?). Open to someone else reviewing instead if they think they can though.

Flags: needinfo?(oj)
Pushed by
Implement the <search> element r=hsivonen,Jamie,emilio

Bug in HTML parser changes, should be fixed in latest diff.

Flags: needinfo?(oj)
Pushed by
Implement the <search> element r=hsivonen,Jamie,emilio
Pushed by
Fix assertion on HTMLEditUtils.cpp. a=test-fix CLOSED TREE
Pushed by
Include nsHtml5HtmlAttributes.h to fix Bp-nu build bustages. a=bustage-fix CLOSED TREE

Backed out for causing wpt failures in html5lib_search-element.html.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-PASS | /html/syntax/parsing/html5lib_search-element.html?run_type=uri | html5lib_search-element.html 114b9f3c8147c0ed8ef3ed1811a9da3f10d74402 - expected FAIL
Flags: needinfo?(oj)
See Also: → 1845254

Fixed WPT expectations (tests were added after patch was created).

Flags: needinfo?(oj)
Pushed by
Implement the <search> element r=hsivonen,Jamie,emilio
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Flags: in-testsuite+
Blocks: 1824176
No longer depends on: 1824176

Just noticed this wasn't in the 118 beta release notes (but in the developer notes). I think this probably should be in the final notes? Apologies.

Release Note Request (optional, but appreciated)
[Why is this notable]: New (minor/a11y) HTML element supported
[Affects Firefox for Android]: Yes
[Suggested wording]: The <search> element is now supported.
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
See Also: → 1856934
You need to log in before you can comment on or make changes to this bug.