Closed Bug 1824187 Opened 9 months ago Closed 8 months ago

Support custom browser to client messages

Categories

(Remote Protocol :: WebDriver BiDi, task, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task
Points:
5

Tracking

(firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox114 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(
URL
)

Details

(Whiteboard: [webdriver:m7][wptsync upstream][webdriver:relnote])

Attachments

(2 files, 1 obsolete file)

Bug 1824187 - [bidi] Add support for channels to script.callFunction and script.addPreloadScript commands.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1824187 - [wdspec] Add tests for channels for script.callFunction and script.addPreloadScript commands.
48 bytes, text/x-phabricator-request
Details | Review

This is not yet in the WebDriver BiDi spec but a PR exists: https://github.com/w3c/webdriver-bidi/pull/361

Here an excerpt from the PR's initial description:

This introduces a script.Channel type which deserializes to a function that when called sends a script.message event with its first argument.

It also changes preload scripts to work as functions rather than just being evaluated directly. This allows arguments to be passed in particuarly for the use of channels so that preload scripts can install event listeners that message back to the client.

Note that we already have pre-load scripts implemented as callFunction so it's the addition of the channelId and sending appropriate events still needs to be done.

Priority: -- → P2
Whiteboard: [webdriver:backlog]
Points: --- → 5
Priority: P2 → P1
Whiteboard: [webdriver:backlog] → [webdriver:m7]

FYI the upstream PR https://github.com/w3c/webdriver-bidi/pull/361 has now been merged so work on this bug is no longer blocked.

Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Attachment #9329254 - Attachment description: Bug 1824187 - [wdspec] Add support for serizialization_options inside channel object. → Bug 1824187 - [wdspec] Add support for serialization_options inside channel object.
Attachment #9329254 - Attachment is obsolete: true
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47e42a280c06
[bidi] Add support for channels to script.callFunction and script.addPreloadScript commands. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/de7e86dfbe99
[wdspec] Add tests for channels for script.callFunction and script.addPreloadScript commands. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39644 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m7] → [webdriver:m7], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/47e42a280c06
https://hg.mozilla.org/mozilla-central/rev/de7e86dfbe99

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Upstream PR merged by moz-wptsync-bot
Blocks: 1806407
Whiteboard: [webdriver:m7], [wptsync upstream] → [webdriver:m7][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.