1824187 - Support custom browser to client messages

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is not yet in the WebDriver BiDi spec but a PR exists: https://github.com/w3c/webdriver-bidi/pull/361

Here an excerpt from the PR's initial description:

This introduces a script.Channel type which deserializes to a function that when called sends a script.message event with its first argument.

It also changes preload scripts to work as functions rather than just being evaluated directly. This allows arguments to be passed in particuarly for the use of channels so that preload scripts can install event listeners that message back to the client.

Note that we already have pre-load scripts implemented as callFunction so it's the addition of the channelId and sending appropriate events still needs to be done.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

FYI the upstream PR https://github.com/w3c/webdriver-bidi/pull/361 has now been merged so work on this bug is no longer blocked.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824187 - [bidi] Add support for channels to script.callFunction and script.addPreloadScript commands.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824187 - [wdspec] Add support for serialization_options inside channel object.

Depends on D175882

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1824187 - [wdspec] Add tests for channels for script.callFunction and script.addPreloadScript commands.

Depends on D175883

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47e42a280c06
[bidi] Add support for channels to script.callFunction and script.addPreloadScript commands. r=webdriver-reviewers,jdescottes,whimboo
https://hg.mozilla.org/integration/autoland/rev/de7e86dfbe99
[wdspec] Add tests for channels for script.callFunction and script.addPreloadScript commands. r=webdriver-reviewers,jdescottes

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39644 for changes under testing/web-platform/tests

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/47e42a280c06
https://hg.mozilla.org/mozilla-central/rev/de7e86dfbe99

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot