Closed Bug 1824199 Opened 2 years ago Closed 2 years ago

[Tabs Tray interactor Refactor] Remove the `expanded` parameter from the inactive tabs header interactor/controller function

Categories

(Fenix :: Tabs, task, P3)

Product:
Fenix
Component:
Tabs
Platform:
All
Android
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: 007, Assigned: 007)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(1 file)

[mozilla-mobile/firefox-android] Bug 1824199 - Remove `expanded` parameter from inactive tabs header click interactor/controller function (#1384)
59 bytes, text/x-github-pull-request
Details | Review

The expanded boolean doesn't need to be passed from the UI to the interactor/controller, so remove the parameter and instead read the current boolean from the app state and invert & pass that to:
appStore.dispatch(AppAction.UpdateInactiveExpanded(...))

and the relevant telemetry

Status: NEW → ASSIGNED
Whiteboard: [fxdroid]
Blocks: tabs-tray-to-compose
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: