1824235 - Remove testGranularity Mask

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, enhancement)

Description

[Tom Ritter [:tjr]]

We can get rid of this pref, and apply the Web Extension exemption by default. We can make a new pref that restricts RFP/RFPLite to PBM.

Comment 1

[Tom Schuster]

What are we going to do about privacy.resistFingerprinting.exemptedDomains ?

Comment 2

[Tom Ritter [:tjr]]

(In reply to Tom Schuster (MoCo) from comment #1)

What are we going to do about privacy.resistFingerprinting.exemptedDomains ?

In this bug I'll be leaving it, but when we tie the ETP prompt into the exemption path it'll get deleted then.

Comment 4

[Tom Ritter [:tjr]]

Running into a few places where this is not as easy as I hoped.

• The time reduction callback for JS, set in SetReduceMicrosecondTimePrecisionCallback - I can probably do the correct thing here by looking at the JSContext
• javascript_options_use_fdlibm_for_sin_cos_tan - This just came up in Bug 1823880, and I wonder if it is something we need to do something about now actually.

Comment 5

[Tom Ritter [:tjr]]

(In reply to Tom Ritter [:tjr] from comment #4)

• The time reduction callback for JS, set in SetReduceMicrosecondTimePrecisionCallback - I can probably do the correct thing here by looking at the JSContext

I actually don't need to do anything. The shouldResistFingerprinting variable inside JS already knows whether or not we are exempting this global, meaning that the PBM behavior and everything else just correctly propagates down. I did spend a bit of time adding a test to ensure it works as expected.

• javascript_options_use_fdlibm_for_sin_cos_tan - This just came up in Bug 1823880, and I wonder if it is something we need to do something about now actually.

This one we will want to fix, eventually. For RFPLite we will not set it, meaning we'll use the fast, fingerprintable functions. RFP and RFP-PBMode-Only will set it; which means that non-PBM mode will use fdlibm if RFP-PBM-Only is set. We can get around to cleaning that up (and enabling it for RFPLite) in Bug 1823880.

Comment 6

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: Remove testGranularityMask from RFP and rename RFPLite r?timhuang

• Create two pbmode prefs that will enable RFP/RFPLite in PBMode
  only. The original prefs will enable it in both modes.
• Make exempting Web Extensions the default behavior
• If there are website exemptions in the exemptedDomains pref,
  exempt them unconditionally
• Use the timezone testing pref to determine whether or not we
  call _tzset on Windows

Depends on D173564

Comment 7

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: Refactor test architecture to support private browsing tests r?timhuang

This changeset makes no functional change to the test.
It changes a function signature to take an options object
and updates the tests to pass it.

Depends on D174014

Comment 8

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: More test structure refactoring r?timhuang

Depends on D174015

Comment 9

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: Add more test structure to support PBM Tests r?timhuang

We are going to need these refactorings in the next patch, but
I'll separate them here to make it easier to see generic logic
separate from the 'we should not be rounding but this looks rounded'
specific exeptions we wind up making.

Depends on D174016

Comment 10

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: Add positive & negative tests that exercise PBM mode r?timhuang

Depends on D174017

Comment 11

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: Abstract the result checking to be used in the worker test r?timhuang

Depends on D174018

Comment 12

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: Cut over existing worker tests r?timhuang

Depends on D174019

Comment 13

[Tom Ritter [:tjr]]

Attachment: Bug 1824235: Add PBM tests for workers r?timhuang

Depends on D174020

Comment 14

[Tom Ritter [:tjr]]

Got try green: https://treeherder.mozilla.org/jobs?repo=try&revision=ab60017d84a74ba491918943cfc45f81909a3aba

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75dae793ba7e
Remove testGranularityMask from RFP r=timhuang
https://hg.mozilla.org/integration/autoland/rev/4fa248349496
Refactor test architecture to support private browsing tests r=timhuang
https://hg.mozilla.org/integration/autoland/rev/99b39ad39149
More test structure refactoring r=timhuang
https://hg.mozilla.org/integration/autoland/rev/c67d6cdac35d
Add more test structure to support PBM Tests r=timhuang
https://hg.mozilla.org/integration/autoland/rev/6dd6dd7c7eaa
Add positive & negative tests that exercise PBM mode r=timhuang
https://hg.mozilla.org/integration/autoland/rev/3a4323845b80
Abstract the result checking to be used in the worker test r=timhuang
https://hg.mozilla.org/integration/autoland/rev/ffedfd68b8eb
Cut over existing worker tests r=timhuang
https://hg.mozilla.org/integration/autoland/rev/eb956b7a7d61
Add PBM tests for workers r=timhuang

Comment 17

[Cristian Tuns]

Backed out for causing multiple failures in test_resistfingerprinting_exempt.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_resistfingerprinting_exempt.js | test_appName_resistFingerprinting - [test_appName_resistFingerprinting : 40] "MyTestAppName" == "Netscape"

Mochitest log: https://treeherder.mozilla.org/logviewer?job_id=411857086&repo=autoland

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/290427746e6e
Remove testGranularityMask from RFP and rename RFPLite r=timhuang
https://hg.mozilla.org/integration/autoland/rev/c9756a818af0
Refactor test architecture to support private browsing tests r=timhuang
https://hg.mozilla.org/integration/autoland/rev/4a661d101842
More test structure refactoring r=timhuang
https://hg.mozilla.org/integration/autoland/rev/a5e88b08cd8b
Add more test structure to support PBM Tests r=timhuang
https://hg.mozilla.org/integration/autoland/rev/a031d3a1451a
Add positive & negative tests that exercise PBM mode r=timhuang
https://hg.mozilla.org/integration/autoland/rev/34ab3f684015
Abstract the result checking to be used in the worker test r=timhuang
https://hg.mozilla.org/integration/autoland/rev/559e05dd06b3
Cut over existing worker tests r=timhuang
https://hg.mozilla.org/integration/autoland/rev/e399a3244418
Add PBM tests for workers r=timhuang

Comment 19

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/290427746e6e
https://hg.mozilla.org/mozilla-central/rev/c9756a818af0
https://hg.mozilla.org/mozilla-central/rev/4a661d101842
https://hg.mozilla.org/mozilla-central/rev/a5e88b08cd8b
https://hg.mozilla.org/mozilla-central/rev/a031d3a1451a
https://hg.mozilla.org/mozilla-central/rev/34ab3f684015
https://hg.mozilla.org/mozilla-central/rev/559e05dd06b3
https://hg.mozilla.org/mozilla-central/rev/e399a3244418