Open Bug 1824250 Opened 1 year ago Updated 1 year ago

Generate better masm for argument-copying loops

Categories

(Core :: JavaScript Engine: JIT, task, P2)

task

Tracking

()

People

(Reporter: iain, Unassigned)

References

(Blocks 1 open bug)

Details

While reviewing Denis's patch here, I recommended that he rewrite his loop pushing arguments onto the stack to use the source address as the iteration variable (after precomputing an end address) to avoid having to increment the source and the iteration counter separately. (example) Then I looked at our current argument-copying code in BaselineCacheIRCompiler.cpp, which mostly doesn't do that (example).

I think we can do a little better here.

You need to log in before you can comment on or make changes to this bug.