Closed Bug 1824264 Opened 2 years ago Closed 1 year ago

Consume ES6 version of ical.js

Categories

(Calendar :: ICAL.js Integration, enhancement)

enhancement

Tracking

(thunderbird_esr115 wontfix)

RESOLVED FIXED
127 Branch
Tracking Status
thunderbird_esr115 --- wontfix

People

(Reporter: leftmostcat, Assigned: darktrojan)

References

Details

Attachments

(1 file)

ical.js recently switched to using ES6 modules. We are currently using a fork of the last ES5 commit and should switch to importing the new ES6 module. Because we use ical.js in a service worker for parsing, this requires support for module workers.

This is also an opportunity to improve our process here. We currently paste the contents of the built ical.js into a portion of the Ical.jsm file, but the change allows us to directly import the built ical.js.

Depends on: 1834360

Do you mean through ./mach vendor?

Depends on: 1886835
Depends on: 1887932

Depends on D205738

The last line of Ical.sys.mjs must be changed to export { ICALmodule as ICAL };

Then it "works", but many tests are failing.

Attachment #9393332 - Attachment is obsolete: true
Attachment #9393332 - Attachment is obsolete: false
Attachment #9393332 - Attachment description: WIP: Bug 1824264 - vendor ical.js tip → WIP: Bug 1824264 - Vendor ical.js tip
Attachment #9393332 - Attachment description: WIP: Bug 1824264 - Vendor ical.js tip → Bug 1824264 - Update ical.js to ES6 version. r=leftmostcat!,rjl!
Assignee: leftmostcat → geoff
Target Milestone: --- → 127 Branch

Pushed by brendan@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/28933f80ce9a
Update ical.js to ES6 version. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Regressions: 1892692
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: