1824326 - './mach lint -l eslint --fix' runs ESlint twice

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

When running ESLint with the --fix option, ESLint is currently being run twice, once to get the count of existing errors, the second time to actually fix the errors (and get a count of the remaining).

Since a full-tree ESLint takes several minutes to run, this is rather wasteful for developer's time.

Getting an accurate count of items fixed from ESLint isn't going to be possible, but we can at least get a count of the files fixed. This will therefore indicate to the developer that at least something was fixed, even if we can't get the exact count.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1824326 - When automatically fixing issues, avoid running ESLint twice. r?#linter-reviewers!

This avoids running ESLint to only get the initial count of errors. Whilst the count of files changed may not be
as accurate, it is still a responable proxy for something being fixed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f075a700e96
When automatically fixing issues, avoid running ESLint twice. r=linter-reviewers,sylvestre

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9f075a700e96