1824479 - WebIDL compiler should permit `[SecureContext]` on namespaces

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement)

Description

[Jim Blandy :jimb]

Mozilla's WebIDL compiler should be extended to implement marking WebIDL namespaces for exposure only in secure contexts. Right now that's an error.

The WebIDL for the WebGPU specification places the [SecureContext] extended attribute on namespaces, but Mozilla's WebIDL compiler doesn't implement this at the moment.

The WebGPU spec says things like:

[Exposed=(Window, DedicatedWorker), SecureContext]
namespace GPUShaderStage {
    const GPUFlagsConstant VERTEX   = 0x1;
    const GPUFlagsConstant FRAGMENT = 0x2;
    const GPUFlagsConstant COMPUTE  = 0x4;
};

but if we try to put this in dom/webidl/WebGPU.webidl, we get an error from the WebIDL compiler:

 0:02.97 Traceback (most recent call last):
 0:02.97   File "<frozen runpy>", line 198, in _run_module_as_main
 0:02.97   File "<frozen runpy>", line 88, in _run_code
 0:02.97   File "/home/jimb/moz/central/python/mozbuild/mozbuild/action/webidl.py", line 19, in <module>
 0:02.97     sys.exit(log_build_task(main, sys.argv[1:]))
 0:02.97              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:02.97   File "/home/jimb/moz/central/python/mozbuild/mozbuild/action/util.py", line 16, in log_build_task
 0:02.97     return f(*args, **kwargs)
 0:02.97            ^^^^^^^^^^^^^^^^^^
 0:02.97   File "/home/jimb/moz/central/python/mozbuild/mozbuild/action/webidl.py", line 15, in main
 0:02.97     manager.generate_build_files()
 0:02.97   File "/home/jimb/moz/central/dom/bindings/mozwebidlcodegen/__init__.py", line 288, in generate_build_files
 0:02.97     self._parse_webidl()
 0:02.97   File "/home/jimb/moz/central/dom/bindings/mozwebidlcodegen/__init__.py", line 384, in _parse_webidl
 0:02.97     parser.parse(data, path)
 0:02.97   File "/home/jimb/moz/central/dom/bindings/parser/WebIDL.py", line 8881, in parse
 0:02.97     self._productions.extend(self.parser.parse(lexer=self.lexer, tracking=True))
 0:02.97                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:02.97   File "/home/jimb/moz/central/third_party/python/ply/ply/yacc.py", line 329, in parse
 0:02.98     return self.parseopt(input, lexer, debug, tracking, tokenfunc)
 0:02.98            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 0:02.98   File "/home/jimb/moz/central/third_party/python/ply/ply/yacc.py", line 821, in parseopt
 0:02.98     p.callable(pslice)
 0:02.98   File "/home/jimb/moz/central/dom/bindings/parser/WebIDL.py", line 7059, in p_Definitions
 0:02.98     p[2].addExtendedAttributes(p[1])
 0:02.98   File "/home/jimb/moz/central/dom/bindings/parser/WebIDL.py", line 2099, in addExtendedAttributes
 0:02.98     raise WebIDLError(
 0:02.98 WebIDL.WebIDLError: error: Unknown extended attribute SecureContext on namespace, /home/jimb/moz/central/dom/webidl/WebGPU.webidl line 421:42
 0:02.98  Exposed=(Window /* ,DedicatedWorker */), SecureContext]
 0:02.98                                           ^
 0:03.19 gmake[4]: *** [Makefile:54: webidl.stub] Error 1
 0:03.19 gmake[3]: *** [/home/jimb/moz/central/config/recurse.mk:99: dom/bindings/export] Error 2

Comment 1

[Jim Blandy :jimb]

The WebIDL for the WebGPU specification places the [SecureContext] extended attribute on namespaces

... or rather, it will once gpuweb#4002 is merged.

Comment 2

[Edgar Chen [:edgar] (OOO ~ 07/13, 07/16 ~ 07/20)]

Attachment: Bug 1824479 - Allow SecureContext on namespace; r?peterv

Comment 3

[Edgar Chen [:edgar] (OOO ~ 07/13, 07/16 ~ 07/20)]

Hi Jim, could you help to try if this WIP patch works for WebGPU, though I have not yet checking the generated code.

Comment 4

[Benjamin Beurdouche [:beurdouche]]

Hi, so I just hit that problem.

Without this patch we need to annotate all individual functions with Secure context.
I tried to apply this patch and to annotate the namespace instead of each function, and this works as expected with my code.

I tested building and running the MLS dom tests locally and on try.
https://treeherder.mozilla.org/jobs?repo=try&revision=5ce2c9706c80892112aa6d85eda6deae8ff4736b

I can also confirm that the namespace was not available outside secure contexts by testing on http://example.com.

It would be very helpful if we can land this :)

Comment 5

[Edgar Chen [:edgar] (OOO ~ 07/13, 07/16 ~ 07/20)]

Thanks for your help in testing and verifying. I am working on getting this landed.

Comment 6

[Edgar Chen [:edgar] (OOO ~ 07/13, 07/16 ~ 07/20)]

Attachment: Bug 1824479 - Fix error message thrown in IDLPartialInterfaceOrNamespace; r?peterv

Comment 7

[Edgar Chen [:edgar] (OOO ~ 07/13, 07/16 ~ 07/20)]

Attachment: Bug 1824479 - Refactor extended attribute handling for IDLInterfaceOrInterfaceMixinOrNamespace; r?peterv

Comment 8

[Edgar Chen [:edgar] (OOO ~ 07/13, 07/16 ~ 07/20)]

Attachment: Bug 1824479 - Move `Exposed` handling to IDLInterfaceOrInterfaceMixinOrNamespace; r?peterv

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09996ad35c95
Fix error message thrown in IDLPartialInterfaceOrNamespace; r=peterv
https://hg.mozilla.org/integration/autoland/rev/a839f895afed
Refactor extended attribute handling for IDLInterfaceOrInterfaceMixinOrNamespace; r=peterv
https://hg.mozilla.org/integration/autoland/rev/70b2d1903a2c
Move `Exposed` handling to IDLInterfaceOrInterfaceMixinOrNamespace; r=peterv
https://hg.mozilla.org/integration/autoland/rev/5e8fc5c0a1d7
Allow SecureContext on namespace; r=peterv

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/09996ad35c95
https://hg.mozilla.org/mozilla-central/rev/a839f895afed
https://hg.mozilla.org/mozilla-central/rev/70b2d1903a2c
https://hg.mozilla.org/mozilla-central/rev/5e8fc5c0a1d7