1824627 - Consider to have a larger cache for MiscContainer

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

This would improve React-Stockcharts-SVG/ZoomTheChart/Sync a tiny bit.
It is the calling of malloc several times in a row (to fill the cache) which seems to help here.
The test creates lots of MiscContainers (>10000), so just increasing the size of the cache doesn't affect too much, since it would be empty all the time.

https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=1a08f77cd113935a40d860941dddbf133dee4656&originalSignature=4586009&newSignature=4586009&framework=13&application=firefox&originalRevision=c36e3b3aa9c26348ef18303e5d07b069c89aaaf2&page=1&showOnlyConfident=1

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1824627 - Consider to have a larger cache for MiscContainer, r=emilio

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

if I remove the old cache https://searchfox.org/mozilla-central/rev/336ff5573f4b7aa8e981429093c051b3f78237ec/dom/base/nsAttrValue.h#563 stylo starts complaining about error[E0412]: cannot find type MiscContainer in module structs.
Error is coming from let container = ptr::structs::MiscContainer(attr);
What magic do I need to tell stylo about MiscContainer?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This is one of those types we don't use in any FFI functions so bindgen doesn't generate them by default. Something like this should do tho:

diff --git a/dom/base/nsAttrValue.cpp b/dom/base/nsAttrValue.cpp
index b4ce9a645971e..2a37dca7d7959 100644
--- a/dom/base/nsAttrValue.cpp
+++ b/dom/base/nsAttrValue.cpp
@@ -144,7 +144,6 @@ void MiscContainer::Evict() {
 }
 
 nsTArray<const nsAttrValue::EnumTable*>* nsAttrValue::sEnumTableArray = nullptr;
-MiscContainer* nsAttrValue::sMiscContainerCache = nullptr;
 
 nsAttrValue::nsAttrValue() : mBits(0) {}
 
diff --git a/dom/base/nsAttrValue.h b/dom/base/nsAttrValue.h
index 2778d3f4819ba..6f5a572c421b8 100644
--- a/dom/base/nsAttrValue.h
+++ b/dom/base/nsAttrValue.h
@@ -560,7 +560,6 @@ class nsAttrValue {
   static void DeallocMiscContainer(MiscContainer* aCont);
 
   static nsTArray<const EnumTable*>* sEnumTableArray;
-  static MiscContainer* sMiscContainerCache;
 
   /**
    * Helper for ParseHTMLDimension and ParseNonzeroHTMLDimension.
diff --git a/layout/style/ServoBindings.toml b/layout/style/ServoBindings.toml
index 0b8fe0e38bfb5..b33691847c5c6 100644
--- a/layout/style/ServoBindings.toml
+++ b/layout/style/ServoBindings.toml
@@ -268,6 +268,7 @@ allowlist-types = [
     "mozilla::MediumFeaturesChangedResult",
     "nsAttrName",
     "nsAttrValue",
+    "MiscContainer",
     "nscolor",
     "nsChangeHint",
     "nsCSSCounterDesc",

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

awsy https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=b296395a9f483e9e05ba2a8fdf6d621040293b1d&newProject=try&newRevision=45b91b0094899d844e24fdf5dae0b54ff4e81338

tests https://treeherder.mozilla.org/jobs?repo=try&revision=af27b971fa6a43f998079feaa6ecf308d0c2146a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de72d720a020
Consider to have a larger cache for MiscContainer, r=emilio

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/de72d720a020