1824667 - Remove nsTextBoxFrame.

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Emilio Cobos Álvarez (:emilio)]

We only use it for middle-cropping. Luckily we don't have use cases for middle cropping that require any of the other features of nsTextBoxFrame, so we can just replace it with something simpler.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1824667 - Factor middle-cropping out of nsFileControlFrame. r=jfkthame,#layout

Factor a MiddleCroppingBlockFrame that does the double reflow shenanigans.

That should both be faster and easier to reason about. The only thing we need
to be careful about is to use the current inline coord from the line layout if
present to compute the real available isize.

Depends on D173601

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1824667 - Remove nsTextBoxFrame. r=jfkthame,#layout

Use a MiddleCroppingBlockFrame subclass that looks at the value attribute
instead. We don't need accesskey etc for these so we can just reuse it as is.

Depends on D173668

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e14f043b6568
Factor middle-cropping out of nsFileControlFrame. r=jfkthame,layout-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bac27e460973
Fix Bp-hybrid bustages on MiddleCroppingBlockFrame.cpp. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47e92b0d5aec
Remove nsTextBoxFrame. r=jwatt

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e14f043b6568
https://hg.mozilla.org/mozilla-central/rev/bac27e460973
https://hg.mozilla.org/mozilla-central/rev/47e92b0d5aec