1824705 - Blackbox all sources in the souremaps x_google_ignoreList field

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Hubert Boma Manilla (:bomsy)]

Library authors have knowledge of framework code that may not be directly relevant to the developers who use their libraries. Such code can be blackboxed by default, which helps web developers to focus on relevant code.

The x_google_ignoreList extension (added by google) extends the current sourcemaps v3 specification to allow library authors define these sources using the x_google_ignoreList property.

Lets read the x_google_ignoreList field from the sourcemap and blackbox all the sources indicated when loading the devtools.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1824705 - [devtools] Add test the sourcemaps ignorelist r=#devtools-reviewers

Depends on D173687

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1824705 - [devtools] Add support for sourcemaps ignore list r=#devtools-reviewers

Also there is a patch to add support for ignoreList to the sourcemap library
https://github.com/mozilla/source-map/pull/481

Depends on D174356

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6d2c97f858d
[devtools] Add support for sourcemaps ignore list r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d67c783fcd63
[devtools] Add test the sourcemaps ignorelist r=devtools-reviewers,nchevobbe

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_misused_characters_in_strings.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4f238caa473a16afb6a2834767fafa32c64ff306

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d67c783fcd637d5bfc510c998b789c8504e216cc&selectedTaskRun=H8FyLHHaR_qI5T_m8YZDew.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=416651506&repo=autoland&lineNumber=1862
https://treeherder.mozilla.org/logviewer?job_id=416661278&repo=autoland&lineNumber=11391

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9d5882be65c
[devtools] Add support for sourcemaps ignore list r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/020cb7b1b953
[devtools] Add test the sourcemaps ignorelist r=devtools-reviewers,nchevobbe

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b9d5882be65c
https://hg.mozilla.org/mozilla-central/rev/020cb7b1b953