1824783 - Annotate fuzziness in clip-path-shape-circle-003.svg and clip-path-shape-circle-004.svg

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Daniel Holbert [:dholbert]]

We and Safari fail clip-path-shape-circle-003.svg and clip-path-shape-circle-004.svg with some fuzzy pixels around a curved edge of a circle:

https://wpt.fyi/results/css/css-masking/clip-path-svg-content/clip-path-shape-circle-003.svg
https://wpt.fyi/results/css/css-masking/clip-path-svg-content/clip-path-shape-circle-004.svg

(Chrome fails by drawing the wrong shape entirely.)

Subtle antialiasing differences along curves (for clipping vs. regular shape drawing) isn't particularly concerning; let's just add a fuzzy annotation.

Comment 1

[Daniel Holbert [:dholbert]]

For clip-path-shape-circle-003.svg:
Firefox:

maxDifference: 64
totalPixels: 171 

Safari:

maxDifference: 64
totalPixels: 184

For clip-path-shape-circle-004.svg:
Firefox:

maxDifference: 64
totalPixels: 67 

Safari:

maxDifference: 63
totalPixels: 76 

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1824783: Annotate observed fuzziness in WPTs clip-path-shape-circle-003.svg and clip-path-shape-circle-004.svg r?#layout-reviewers

Firefox and Safari render these tests with an essentially-identical-looking
testcase and reference case, except for some subtle differences in the pixels
along the curved edges of the circle. These seem to be uninteresting
antialiasing differences between the draw-a-curved-shape-with-solid-fill
vs. mask-a-solid-fill-area-using-a-curved-shape codepaths.

This commit just annotates these tests with a fuzzy tolerance taken from the
observed fuzzy-metrics shown for the test failures on wpt.fyi.

Comment 3

[Daniel Holbert [:dholbert]]

Try: https://treeherder.mozilla.org/jobs?repo=try&revision=555de20ee26b47be4d5a13c641fb5e12133a1ca8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c6415046d9c
Annotate observed fuzziness in WPTs clip-path-shape-circle-003.svg and clip-path-shape-circle-004.svg r=jwatt

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39230 for changes under testing/web-platform/tests

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c6415046d9c

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot